From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gbenson@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/7] Pull out common parts of _initialize_{i386,amd64}_linux_nat
Date: Fri, 27 Jun 2014 09:21:00 -0000 [thread overview]
Message-ID: <201406270921.s5R9LP2I002532@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1403860209-475-5-git-send-email-gbenson@redhat.com> (message from Gary Benson on Fri, 27 Jun 2014 10:10:06 +0100)
> From: Gary Benson <gbenson@redhat.com>
> Date: Fri, 27 Jun 2014 10:10:06 +0100
>
> This commit adds two new helpers, x86_linux_create_target
> and x86_linux_register_target, to hold the parts of
> _initialize_i386_linux_nat and _initialize_amd64_linux_nat
> which are common.
Please stick to the existing naming convention. Functions in i386-*.c
start with i386_, functions in amd64-*.c start with amd64_.
>
> gdb/
> 2014-06-27 Gary Benson <gbenson@redhat.com>
>
> * amd64-linux-nat.c (x86_linux_create_target): New function.
> (x86_linux_register_target): Likewise.
> (_initialize_amd64_linux_nat): Delegate to the above new functions.
> * i386-linux-nat.c (x86_linux_create_target): New function.
> (x86_linux_register_target): Likewise.
> (_initialize_i386_linux_nat): Delegate to the above new functions.
next prev parent reply other threads:[~2014-06-27 9:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 9:10 [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c Gary Benson
2014-06-27 9:10 ` [PATCH 3/7] Merge ps_get_thread_area Gary Benson
2014-06-27 9:10 ` [PATCH 6/7] Move duplicated code into new files Gary Benson
2014-06-27 9:10 ` [PATCH 2/7] Merge {i386,amd64}_linux_read_description Gary Benson
2014-06-27 9:10 ` [PATCH 4/7] Pull out common parts of _initialize_{i386,amd64}_linux_nat Gary Benson
2014-06-27 9:21 ` Mark Kettenis [this message]
2014-06-27 9:26 ` [PATCH 5/7] Comment and whitespace changes Gary Benson
2014-06-27 9:26 ` [PATCH 1/7] Rename identical functions Gary Benson
2014-06-27 9:28 ` [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c Mark Kettenis
2014-06-27 10:39 ` Pedro Alves
2014-06-27 10:43 ` Pedro Alves
2014-06-27 10:54 ` Pedro Alves
2014-06-27 11:57 ` Gary Benson
2014-06-27 9:51 ` [PATCH 7/7] Tidy #include lists Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201406270921.s5R9LP2I002532@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox