Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>, gbenson@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c
Date: Fri, 27 Jun 2014 10:54:00 -0000	[thread overview]
Message-ID: <53AD4D51.3030302@redhat.com> (raw)
In-Reply-To: <53AD49F1.70709@redhat.com>

On 06/27/2014 11:39 AM, Pedro Alves wrote:
> The resulting #ifdefery quite reasonable, IMNSHO -- it'd be bad if there
> were lots of different combinations of symbols we'd have to #ifdef on,
> but there's really only a few #ifdef __x86_64__.  So if it's
> spaghetti, it's still dry, raw, straight and neatly lined up
> in the package.  :-)

Ah, I found one bit where there's more #ifdefery than necessary.
So the spaghetti did catch some moisture.  :-)

Gary, please compare your resulting x86_linux_read_description
with gdbserver's x86_linux_read_description.  Notice how it
has fewer #ifdef blocks.  Could you rework your version of the
function in that direction please?

Thanks,
-- 
Pedro Alves


  parent reply	other threads:[~2014-06-27 10:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27  9:10 Gary Benson
2014-06-27  9:10 ` [PATCH 6/7] Move duplicated code into new files Gary Benson
2014-06-27  9:10 ` [PATCH 3/7] Merge ps_get_thread_area Gary Benson
2014-06-27  9:10 ` [PATCH 4/7] Pull out common parts of _initialize_{i386,amd64}_linux_nat Gary Benson
2014-06-27  9:21   ` Mark Kettenis
2014-06-27  9:10 ` [PATCH 2/7] Merge {i386,amd64}_linux_read_description Gary Benson
2014-06-27  9:26 ` [PATCH 5/7] Comment and whitespace changes Gary Benson
2014-06-27  9:26 ` [PATCH 1/7] Rename identical functions Gary Benson
2014-06-27  9:28 ` [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c Mark Kettenis
2014-06-27 10:39   ` Pedro Alves
2014-06-27 10:43     ` Pedro Alves
2014-06-27 10:54     ` Pedro Alves [this message]
2014-06-27 11:57   ` Gary Benson
2014-06-27  9:51 ` [PATCH 7/7] Tidy #include lists Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AD4D51.3030302@redhat.com \
    --to=palves@redhat.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox