Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c
Date: Fri, 27 Jun 2014 11:57:00 -0000	[thread overview]
Message-ID: <20140627115709.GA11337@blade.nx> (raw)
In-Reply-To: <201406270928.s5R9SZPG020219@glazunov.sibelius.xs4all.nl>

Hi Mark,

Mark Kettenis wrote:
> > From: Gary Benson <gbenson@redhat.com>
> > Date: Fri, 27 Jun 2014 10:10:02 +0100
> > 
> > This series refactors the shared code in {i386,amd64}-linux-nat.c into
> > the new files x86-linux-nat.[ch] and i386-linux-nat.h.
[snip]
> > Is this ok to commit?
> 
> Sorry, no.  Perhaps more code can be shared between i386-linux-nat.c
> and amd64-linux-nat.c, but this goes too far and turns things into
> #ifdef spagetthi.  It also breaks established naming conventions.

In hindsight the "Merge {i386,amd64}_linux_read_description" patch
is pretty ugly.  I'll rework it as per Pedro's suggestion elsewhere
in this thread.

Regarding the naming convention, there's a problem on the GDB
side (as opposed to gdbserver) in that "i386" is overloaded.
In some places it means "i386 and amd64" and in other places
it means "i386 (not amd64)".  This makes things difficult to
understand, so I've adopted the gdbserver's convention where
"x86" means "i386 and x86_64" and "i386" means "i386 (not amd64)".

Thanks,
Gary

-- 
http://gbenson.net/


  parent reply	other threads:[~2014-06-27 11:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27  9:10 Gary Benson
2014-06-27  9:10 ` [PATCH 3/7] Merge ps_get_thread_area Gary Benson
2014-06-27  9:10 ` [PATCH 6/7] Move duplicated code into new files Gary Benson
2014-06-27  9:10 ` [PATCH 2/7] Merge {i386,amd64}_linux_read_description Gary Benson
2014-06-27  9:10 ` [PATCH 4/7] Pull out common parts of _initialize_{i386,amd64}_linux_nat Gary Benson
2014-06-27  9:21   ` Mark Kettenis
2014-06-27  9:26 ` [PATCH 5/7] Comment and whitespace changes Gary Benson
2014-06-27  9:26 ` [PATCH 1/7] Rename identical functions Gary Benson
2014-06-27  9:28 ` [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c Mark Kettenis
2014-06-27 10:39   ` Pedro Alves
2014-06-27 10:43     ` Pedro Alves
2014-06-27 10:54     ` Pedro Alves
2014-06-27 11:57   ` Gary Benson [this message]
2014-06-27  9:51 ` [PATCH 7/7] Tidy #include lists Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140627115709.GA11337@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox