From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7418 invoked by alias); 27 Jun 2014 09:21:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7405 invoked by uid 89); 27 Jun 2014 09:21:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Jun 2014 09:21:34 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s5R9LQ1i000682; Fri, 27 Jun 2014 11:21:26 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s5R9LP2I002532; Fri, 27 Jun 2014 11:21:25 +0200 (CEST) Date: Fri, 27 Jun 2014 09:21:00 -0000 Message-Id: <201406270921.s5R9LP2I002532@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: gbenson@redhat.com CC: gdb-patches@sourceware.org In-reply-to: <1403860209-475-5-git-send-email-gbenson@redhat.com> (message from Gary Benson on Fri, 27 Jun 2014 10:10:06 +0100) Subject: Re: [PATCH 4/7] Pull out common parts of _initialize_{i386,amd64}_linux_nat References: <1403860209-475-1-git-send-email-gbenson@redhat.com> <1403860209-475-5-git-send-email-gbenson@redhat.com> X-SW-Source: 2014-06/txt/msg00921.txt.bz2 > From: Gary Benson > Date: Fri, 27 Jun 2014 10:10:06 +0100 > > This commit adds two new helpers, x86_linux_create_target > and x86_linux_register_target, to hold the parts of > _initialize_i386_linux_nat and _initialize_amd64_linux_nat > which are common. Please stick to the existing naming convention. Functions in i386-*.c start with i386_, functions in amd64-*.c start with amd64_. > > gdb/ > 2014-06-27 Gary Benson > > * amd64-linux-nat.c (x86_linux_create_target): New function. > (x86_linux_register_target): Likewise. > (_initialize_amd64_linux_nat): Delegate to the above new functions. > * i386-linux-nat.c (x86_linux_create_target): New function. > (x86_linux_register_target): Likewise. > (_initialize_i386_linux_nat): Delegate to the above new functions.