From: Joel Brobecker <brobecker@adacore.com>
To: Brad Mouring <bmouring@ni.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/source.c: Fix source path substitution
Date: Wed, 28 May 2014 16:15:00 -0000 [thread overview]
Message-ID: <20140528161531.GA4289@adacore.com> (raw)
In-Reply-To: <20140528160120.GA32338@linuxgetsreal>
> > > Will do. I take it this info belongs in the commit message, or would
> > > you rather it be a cover letter-type email?
> >
> > Can you explain which info you are referring to?
> The details concerning the issue that I'm fixing
Generally speaking, the best place for explaining why you do what
you do is the code. The more goes into the code, the better (usually).
The rest should be in the revision log. The idea is to help us avoid
doing most of the archeology based purely on the repository. Tracking
emails is quite a bit more labor-intensive...
For an example of a commit that I thought was pretty nice, take a look at:
commit 6a3cb8e88a739c967bb9b2d8774bf96b87a7fda4
Author: Pedro Alves <palves@redhat.com>
Date: Wed May 21 18:30:47 2014 +0100
Allow making GDB not automatically connect to the native target.
It provides the context, shows what we had before, what we get now,
motivation, etc.
> One additional question that I had that was not answered on the IRC
> channel is I wanted some validation that such a simple change does
> not require copyright assignment since this fixes existing functionality
> and provides no new, patentable functionality.
If you keep your contributions to obvious changes, and/or small ones,
they are deemed "not legally significant", and we can accept one
or two of them. The guideline is that it should be under 15 lines.
--
Joel
next prev parent reply other threads:[~2014-05-28 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 21:02 Brad Mouring
2014-05-23 23:50 ` Joel Brobecker
2014-05-24 0:00 ` Joel Brobecker
2014-05-27 13:17 ` Brad Mouring
2014-05-27 18:10 ` Joel Brobecker
2014-05-28 16:01 ` Brad Mouring
2014-05-28 16:15 ` Joel Brobecker [this message]
2014-05-28 22:42 ` Fix matching path substitution rule listing, add tests Brad Mouring
2014-05-28 22:42 ` [PATCH 1/2] testsuite/subst: Add tests for printing matches Brad Mouring
2014-05-28 22:42 ` [PATCH 2/2] gdb/source.c: Fix matching path substitute rule listing Brad Mouring
2014-06-02 15:14 ` Joel Brobecker
2014-06-02 18:28 ` [PATCH] " Brad Mouring
2014-06-02 20:27 ` Brad Mouring
2014-06-02 20:45 ` Joel Brobecker
2014-06-02 20:55 ` Brad Mouring
2014-06-03 14:25 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528161531.GA4289@adacore.com \
--to=brobecker@adacore.com \
--cc=bmouring@ni.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox