Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Brad Mouring" <bmouring@ni.com>
To: gdb-patches@sourceware.org
Cc: Brad Mouring <brad.mouring@ni.com>
Subject: [PATCH] gdb/source.c: Fix source path substitution
Date: Fri, 23 May 2014 21:02:00 -0000	[thread overview]
Message-ID: <1400878971-6311-1-git-send-email-brad.mouring@ni.com> (raw)

Substitute source path functionality never worked on non-Windows
platforms due to straight strcmp tests returning non-zeros.

Signed-off-by: Brad Mouring <brad.mouring@ni.com>
---
 gdb/source.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/source.c b/gdb/source.c
index c77a4f4..7b59d77 100644
--- a/gdb/source.c
+++ b/gdb/source.c
@@ -946,7 +946,7 @@ substitute_path_rule_matches (const struct substitute_path_rule *rule,
   strncpy (path_start, path, from_len);
   path_start[from_len] = '\0';
 
-  if (FILENAME_CMP (path_start, rule->from) != 0)
+  if (filename_ncmp (path_start, rule->from, from_len) != 0)
     return 0;
 
   /* Make sure that the region in the path that matches the substitution
@@ -1897,7 +1897,7 @@ show_substitute_path_command (char *args, int from_tty)
 
   while (rule != NULL)
     {
-      if (from == NULL || FILENAME_CMP (rule->from, from) == 0)
+      if (from == NULL || filename_ncmp (rule->from, from, strlen(rule->from)) == 0)
         printf_filtered ("  `%s' -> `%s'.\n", rule->from, rule->to);
       rule = rule->next;
     }
-- 
1.8.3-rc3


             reply	other threads:[~2014-05-23 21:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 21:02 Brad Mouring [this message]
2014-05-23 23:50 ` Joel Brobecker
2014-05-24  0:00   ` Joel Brobecker
2014-05-27 13:17     ` Brad Mouring
2014-05-27 18:10       ` Joel Brobecker
2014-05-28 16:01         ` Brad Mouring
2014-05-28 16:15           ` Joel Brobecker
2014-05-28 22:42             ` Fix matching path substitution rule listing, add tests Brad Mouring
2014-05-28 22:42               ` [PATCH 2/2] gdb/source.c: Fix matching path substitute rule listing Brad Mouring
2014-06-02 15:14                 ` Joel Brobecker
2014-06-02 18:28                   ` [PATCH] " Brad Mouring
2014-06-02 20:27                     ` Brad Mouring
2014-06-02 20:45                       ` Joel Brobecker
2014-06-02 20:55                         ` Brad Mouring
2014-06-03 14:25                           ` Joel Brobecker
2014-05-28 22:42               ` [PATCH 1/2] testsuite/subst: Add tests for printing matches Brad Mouring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400878971-6311-1-git-send-email-brad.mouring@ni.com \
    --to=bmouring@ni.com \
    --cc=brad.mouring@ni.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox