From: "Brad Mouring" <bmouring@ni.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Brad Mouring <bmouring@ni.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/source.c: Fix source path substitution
Date: Wed, 28 May 2014 16:01:00 -0000 [thread overview]
Message-ID: <20140528160120.GA32338@linuxgetsreal> (raw)
In-Reply-To: <20140527181033.GA3357@adacore.com>
On Tue, May 27, 2014 at 11:10:33AM -0700, Joel Brobecker wrote:
> > > > First of all, the administrative stuff. There are a few important pieces
> > > > missing from your subscription. I invite you read the file gdb/CONTRIBUTE
> > > > which should explain it all. Do not hesitate to ask questions if needed.
> >
> > Will do. I take it this info belongs in the commit message, or would
> > you rather it be a cover letter-type email?
>
> Can you explain which info you are referring to?
The details concerning the issue that I'm fixing
>
> About cover letters, they typically seem to be used when submitting
> a series of patch, rather than a patch alone, to introduce the series,
> or to provide info that really does not belong in the revision log,
> Other than that, having the details in the revision log is usually
> mostly positive, but we can help you with our review if we think
> we can help improving it.
>
> --
> Joel
One additional question that I had that was not answered on the IRC
channel is I wanted some validation that such a simple change does
not require copyright assignment since this fixes existing functionality
and provides no new, patentable functionality.
-Brad
next prev parent reply other threads:[~2014-05-28 16:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 21:02 Brad Mouring
2014-05-23 23:50 ` Joel Brobecker
2014-05-24 0:00 ` Joel Brobecker
2014-05-27 13:17 ` Brad Mouring
2014-05-27 18:10 ` Joel Brobecker
2014-05-28 16:01 ` Brad Mouring [this message]
2014-05-28 16:15 ` Joel Brobecker
2014-05-28 22:42 ` Fix matching path substitution rule listing, add tests Brad Mouring
2014-05-28 22:42 ` [PATCH 2/2] gdb/source.c: Fix matching path substitute rule listing Brad Mouring
2014-06-02 15:14 ` Joel Brobecker
2014-06-02 18:28 ` [PATCH] " Brad Mouring
2014-06-02 20:27 ` Brad Mouring
2014-06-02 20:45 ` Joel Brobecker
2014-06-02 20:55 ` Brad Mouring
2014-06-03 14:25 ` Joel Brobecker
2014-05-28 22:42 ` [PATCH 1/2] testsuite/subst: Add tests for printing matches Brad Mouring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528160120.GA32338@linuxgetsreal \
--to=bmouring@ni.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox