From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8597 invoked by alias); 28 May 2014 16:01:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8575 invoked by uid 89); 28 May 2014 16:01:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: ni.com Received: from skprod3.natinst.com (HELO ni.com) (130.164.80.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 28 May 2014 16:01:26 +0000 Received: from us-aus-mgwout1.amer.corp.natinst.com (nb-chan1-1338.natinst.com [130.164.19.134]) by us-aus-skprod3.natinst.com (8.14.5/8.14.5) with ESMTP id s4SG1LDi032457; Wed, 28 May 2014 11:01:21 -0500 Received: from linuxgetsreal.amer.corp.natinst.com ([130.164.14.198]) by us-aus-mgwout1.amer.corp.natinst.com (Lotus Domino Release 8.5.3FP5) with SMTP id 2014052811012063-427285 ; Wed, 28 May 2014 11:01:20 -0500 Received: by linuxgetsreal.amer.corp.natinst.com (sSMTP sendmail emulation); Wed, 28 May 2014 11:01:20 -0500 From: "Brad Mouring" Date: Wed, 28 May 2014 16:01:00 -0000 To: Joel Brobecker Cc: Brad Mouring , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/source.c: Fix source path substitution Message-ID: <20140528160120.GA32338@linuxgetsreal> References: <1400878971-6311-1-git-send-email-brad.mouring@ni.com> <20140523234959.GX22822@adacore.com> <20140524000034.GY22822@adacore.com> <20140527131716.GA8300@linuxgetsreal> <20140527181033.GA3357@adacore.com> MIME-Version: 1.0 In-Reply-To: <20140527181033.GA3357@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96,1.0.14,0.0.0000 definitions=2014-05-28_04:2014-05-28,2014-05-28,1970-01-01 signatures=0 X-SW-Source: 2014-05/txt/msg00691.txt.bz2 On Tue, May 27, 2014 at 11:10:33AM -0700, Joel Brobecker wrote: > > > > First of all, the administrative stuff. There are a few important pieces > > > > missing from your subscription. I invite you read the file gdb/CONTRIBUTE > > > > which should explain it all. Do not hesitate to ask questions if needed. > > > > Will do. I take it this info belongs in the commit message, or would > > you rather it be a cover letter-type email? > > Can you explain which info you are referring to? The details concerning the issue that I'm fixing > > About cover letters, they typically seem to be used when submitting > a series of patch, rather than a patch alone, to introduce the series, > or to provide info that really does not belong in the revision log, > Other than that, having the details in the revision log is usually > mostly positive, but we can help you with our review if we think > we can help improving it. > > -- > Joel One additional question that I had that was not answered on the IRC channel is I wanted some validation that such a simple change does not require copyright assignment since this fixes existing functionality and provides no new, patentable functionality. -Brad