From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21868 invoked by alias); 28 May 2014 16:15:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21740 invoked by uid 89); 28 May 2014 16:15:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 28 May 2014 16:15:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C383C1161F4; Wed, 28 May 2014 12:15:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ANSF-vbBpsQK; Wed, 28 May 2014 12:15:33 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 928981160FD; Wed, 28 May 2014 12:15:33 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EA4CA40E2A; Wed, 28 May 2014 09:15:31 -0700 (PDT) Date: Wed, 28 May 2014 16:15:00 -0000 From: Joel Brobecker To: Brad Mouring Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/source.c: Fix source path substitution Message-ID: <20140528161531.GA4289@adacore.com> References: <1400878971-6311-1-git-send-email-brad.mouring@ni.com> <20140523234959.GX22822@adacore.com> <20140524000034.GY22822@adacore.com> <20140527131716.GA8300@linuxgetsreal> <20140527181033.GA3357@adacore.com> <20140528160120.GA32338@linuxgetsreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140528160120.GA32338@linuxgetsreal> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00692.txt.bz2 > > > Will do. I take it this info belongs in the commit message, or would > > > you rather it be a cover letter-type email? > > > > Can you explain which info you are referring to? > The details concerning the issue that I'm fixing Generally speaking, the best place for explaining why you do what you do is the code. The more goes into the code, the better (usually). The rest should be in the revision log. The idea is to help us avoid doing most of the archeology based purely on the repository. Tracking emails is quite a bit more labor-intensive... For an example of a commit that I thought was pretty nice, take a look at: commit 6a3cb8e88a739c967bb9b2d8774bf96b87a7fda4 Author: Pedro Alves Date: Wed May 21 18:30:47 2014 +0100 Allow making GDB not automatically connect to the native target. It provides the context, shows what we had before, what we get now, motivation, etc. > One additional question that I had that was not answered on the IRC > channel is I wanted some validation that such a simple change does > not require copyright assignment since this fixes existing functionality > and provides no new, patentable functionality. If you keep your contributions to obvious changes, and/or small ones, they are deemed "not legally significant", and we can accept one or two of them. The guideline is that it should be under 15 lines. -- Joel