Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: "Agovic, Sanimir" <sanimir.agovic@intel.com>
Cc: "tromey@redhat.com" <tromey@redhat.com>,
	"Boell, Keven" <keven.boell@intel.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v5 10/15] vla: evaluate operand of sizeof if its type is a vla
Date: Wed, 19 Mar 2014 15:12:00 -0000	[thread overview]
Message-ID: <20140319151230.GG4282@adacore.com> (raw)
In-Reply-To: <0377C58828D86C4588AEEC42FC3B85A7177464DE@IRSMSX105.ger.corp.intel.com>

> If the operand passed to sizeof evaluates to a variable length array
> type then C99 requires that the size of the operand is evaluated at
> runtime (otherwise at compile time).
> 
> 1| int vla[n][m];
> 
> sizeof(vla[0])      // Operand type is a variable length type, size is evaluated at runtime
> sizeof(vla[0][0])   // Operand type is an int, size is evaluated at compile time 
> 
> If the expression contains a side effects it is evaluated too
> 
> sizeof(vla[i++])    // i gets modified as the operand is evaluated at runtime
> sizeof(vla[i++][0]) // no modifications, operand type evaluates to int

Very interesting! I guess whoever is writing ...

    sizeof(vla[i++][0])

... instead of ...

    sizeof(vla[i + 1][0])

... is trying to shoot himself in the foot!

Thanks for the explanation. I confess that the C RM is often somewhat
obscure to me.

> I addressed all of your issues below.

Thanks! I look forward to v6 :). Hopefully that'll be the final
iteration. FYI: I have one patch already that's dependent on your patch
series, and it has to do with handling of "ptype dynamic_sized_array"
in Ada.

Thanks!
-- 
Joel


  reply	other threads:[~2014-03-19 15:12 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 16:27 [PATCH v5 00/15] C99 variable length array support Sanimir Agovic
2014-02-06 16:27 ` [PATCH v5 08/15] vla: support for DW_AT_count Sanimir Agovic
2014-02-28 16:53   ` Joel Brobecker
2014-03-12 13:51     ` Agovic, Sanimir
2014-03-13 15:36       ` Joel Brobecker
2014-02-06 16:27 ` [PATCH v5 04/15] vla: enable sizeof operator to work with variable length arrays Sanimir Agovic
2014-02-06 16:27 ` [PATCH v5 11/15] test: cover subranges with present DW_AT_count attribute Sanimir Agovic
2014-02-28 17:52   ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 12/15] test: multi-dimensional c99 vla Sanimir Agovic
2014-02-28 17:58   ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence Sanimir Agovic
2014-02-07 10:27   ` Joel Brobecker
2014-02-07 12:27     ` Agovic, Sanimir
2014-02-28 17:09   ` Joel Brobecker
2014-03-12 13:40     ` Agovic, Sanimir
2014-03-13 16:00     ` Joel Brobecker
2014-03-19 15:35       ` Agovic, Sanimir
2014-02-06 16:28 ` [PATCH v5 03/15] type: add c99 variable length array support Sanimir Agovic
2014-02-28 16:27   ` Joel Brobecker
2014-04-08  6:41     ` Agovic, Sanimir
2014-04-08 12:49       ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 13/15] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2014-02-28 18:01   ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 05/15] vla: enable sizeof operator for indirection Sanimir Agovic
2014-02-06 16:28 ` [PATCH v5 10/15] vla: evaluate operand of sizeof if its type is a vla Sanimir Agovic
2014-02-28 17:37   ` Joel Brobecker
2014-03-19 12:55     ` Agovic, Sanimir
2014-03-19 15:12       ` Joel Brobecker [this message]
2014-02-06 16:28 ` [PATCH v5 01/15] refactoring: rename create_range_type to create_static_range_type Sanimir Agovic
2014-02-27 22:03   ` Joel Brobecker
2014-02-28 11:02     ` Agovic, Sanimir
2014-02-06 16:28 ` [PATCH v5 15/15] test: add mi vla test Sanimir Agovic
2014-02-28 18:07   ` Joel Brobecker
2014-03-12 12:53     ` Agovic, Sanimir
2014-02-06 16:28 ` [PATCH v5 06/15] vla: update type from newly created value Sanimir Agovic
2014-02-06 16:28 ` [PATCH v5 02/15] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2014-02-06 16:28 ` [PATCH v5 14/15] test: basic c99 vla tests for C primitives Sanimir Agovic
2014-02-28 18:04   ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 07/15] vla: print "variable length" for unresolved dynamic bounds Sanimir Agovic
2014-02-09  3:49 ` [PATCH v5 00/15] C99 variable length array support Joel Brobecker
2014-02-10  4:33   ` Joel Brobecker
2014-02-17 20:22     ` Joel Brobecker
2014-02-26 14:05     ` Joel Brobecker
2014-03-03 16:51       ` Agovic, Sanimir
2014-02-28 18:13 ` status update: " Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140319151230.GG4282@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keven.boell@intel.com \
    --cc=sanimir.agovic@intel.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox