Re: [PATCH v5 13/15] test: evaluate pointers to C99 vla correctly.

[Joel Brobecker <brobecker@adacore.com>]

On Thu, Feb 06, 2014 at 05:27:34PM +0100, Sanimir Agovic wrote:
> 2013-10-18  Keven Boell  <keven.boell@intel.com>
>             Sanimir Agovic  <sanimir.agovic@intel.com>
> 
> gdb/testsuite:
> 	* gdb.base/vla-ptr.c: New. Test source file
> 	for testing pointers to VLA's in C.
> 	* gdb.base/vla-ptr.exp: New. Tests ensure that
> 	the evaluation of pointers to VLA's work
> 	correctly in C.

Same as the previous test: You don't need to say in the ChangeLog
file what the purpose of files are.

And I have the same kind of minor comments I made in another test
patch. Also pre-approved with those comments addressed.

> 
> 
> Signed-off-by: Sanimir Agovic <sanimir.agovic@intel.com>
> ---
>  gdb/testsuite/gdb.base/vla-ptr.c   | 63 ++++++++++++++++++++++++++++++++++++++
>  gdb/testsuite/gdb.base/vla-ptr.exp | 52 +++++++++++++++++++++++++++++++
>  2 files changed, 115 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.base/vla-ptr.c
>  create mode 100644 gdb/testsuite/gdb.base/vla-ptr.exp
> 
> diff --git a/gdb/testsuite/gdb.base/vla-ptr.c b/gdb/testsuite/gdb.base/vla-ptr.c
> new file mode 100644
> index 0000000..85c41e0
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/vla-ptr.c
> @@ -0,0 +1,63 @@
> +/* This testcase is part of GDB, the GNU debugger.
> +
> +   Copyright 2013 Free Software Foundation, Inc.

Please update the copyright year range...

> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +#define SIZE 5
> +
> +void
> +foo (int n, int vla_ptr[n])
> +{
> +  return;         /* foo_bp */
> +}
> +
> +void
> +bar (int *vla_ptr)
> +{
> +  return;         /* bar_bp */
> +}
> +
> +void
> +vla_func (int n)
> +{
> +  int vla[n];
> +  int (*vla_ptr)[n];
> +  typedef int typedef_vla[n];
> +  typedef_vla td_vla;
> +  int i;
> +
> +  for (i = 0; i < n; i++)
> +    {
> +      vla[i] = 2+i;
> +      td_vla[i] = 4+i;
> +    }
> +
> +  foo(n, vla);
> +  bar(vla);
> +
> +  vla_ptr = &vla;
> +
> +  typedef_vla *td_ptr = &td_vla;  /* vla_ptr_assigned */
> +
> +  return;         /* typedef_ptr_assigned */
> +}
> +
> +int
> +main ()

Missing "void" as arg.

> -- 
> 1.8.4.2

> +{
> +  vla_func(SIZE);
> +
> +  return 0;
> +}
> diff --git a/gdb/testsuite/gdb.base/vla-ptr.exp b/gdb/testsuite/gdb.base/vla-ptr.exp
> new file mode 100644
> index 0000000..a7785b0
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/vla-ptr.exp
> @@ -0,0 +1,52 @@
> +# Copyright 2013 Free Software Foundation, Inc.

Copyright year range...

> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +standard_testfile ".c"

No ".c"...

> +
> +if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
> +    return -1
> +}
> +
> +if ![runto_main] {
> +    return -1
> +}
> +
> +set sizeof_int [get_sizeof "int" 4]
> +
> +# Check that VLA passed to function (pointer) points to the first element.
> +gdb_breakpoint [gdb_get_line_number "foo_bp"]
> +gdb_continue_to_breakpoint "foo_bp"
> +gdb_test "print vla_ptr" "\\\(int \\\*\\\) $hex" "print vla_ptr (foo)"
> +gdb_test "print *vla_ptr" "\\$\\d+ = 2" "print *vla_ptr (foo)"
> +
> +gdb_breakpoint [gdb_get_line_number "bar_bp"]
> +gdb_continue_to_breakpoint "bar_bp"
> +gdb_test "print vla_ptr" "\\\(int \\\*\\\) $hex" "print vla_ptr (bar)"
> +gdb_test "print *vla_ptr" "\\$\\d+ = 2" "print *vla_ptr (bar)"
> +
> +gdb_breakpoint [gdb_get_line_number "vla_ptr_assigned"]
> +gdb_continue_to_breakpoint "vla_ptr_assigned"
> +gdb_test "print *vla_ptr" "\\$\\d+ = \\\{2, 3, 4, 5, 6\\\}" \
> +         "print *vla_ptr (vla_func)"
> +
> +# Calculate the overall size of the vla.
> +set sizeof_vla [ expr "5" * "$sizeof_int" ]
> +gdb_test "print sizeof(*vla_ptr)" "\\$\\d+ = ${sizeof_vla}" \
> +         "print sizeof(*vla_ptr) (vla_func)"
> +
> +gdb_breakpoint [gdb_get_line_number "typedef_ptr_assigned"]
> +gdb_continue_to_breakpoint "typedef_ptr_assigned"
> +gdb_test "print td_vla" "\\$\\d+ = \\\{4, 5, 6, 7, 8\\\}" "print td_vla"
> +gdb_test "print *td_ptr" "\\$\\d+ = \\\{4, 5, 6, 7, 8\\\}" "print *td_ptr"

Please remove the $N checking in the expected output of "print" tests.

> -- 
> 1.8.4.2

-- 
Joel