From: Sanimir Agovic <sanimir.agovic@intel.com>
To: tromey@redhat.com, brobecker@adacore.com
Cc: keven.boell@intel.com, gdb-patches@sourceware.org
Subject: [PATCH v5 04/15] vla: enable sizeof operator to work with variable length arrays
Date: Thu, 06 Feb 2014 16:27:00 -0000 [thread overview]
Message-ID: <1391704056-25246-5-git-send-email-sanimir.agovic@intel.com> (raw)
In-Reply-To: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com>
In C99 the sizeof operator computes the size of a variable length array
at runtime (6.5.3.4 The sizeof operator). This patch reflects the semantic
change in the debugger.
We now are able to get the size of a vla:
1| void foo (size_t n) {
2| int vla[n];
3| }
(gdb) p sizeof(vla)
yields N * sizeof(int).
2013-10-18 Sanimir Agovic <sanimir.agovic@intel.com>
Keven Boell <keven.boell@intel.com>
* eval.c (evaluate_subexp_for_sizeof) <OP_VAR_VALUE>: If the type
passed to sizeof is dynamic evaluate the argument to compute the length.
Signed-off-by: Sanimir Agovic <sanimir.agovic@intel.com>
---
gdb/eval.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/eval.c b/gdb/eval.c
index 9d81a92..a81e789 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -3041,8 +3041,14 @@ evaluate_subexp_for_sizeof (struct expression *exp, int *pos)
return value_from_longest (size_type, (LONGEST) TYPE_LENGTH (type));
case OP_VAR_VALUE:
- (*pos) += 4;
type = check_typedef (SYMBOL_TYPE (exp->elts[pc + 2].symbol));
+ if (is_dynamic_type (type))
+ {
+ val = evaluate_subexp (NULL_TYPE, exp, pos, EVAL_NORMAL);
+ type = value_type (val);
+ }
+ else
+ (*pos) += 4;
return
value_from_longest (size_type, (LONGEST) TYPE_LENGTH (type));
--
1.8.4.2
next prev parent reply other threads:[~2014-02-06 16:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 16:27 [PATCH v5 00/15] C99 variable length array support Sanimir Agovic
2014-02-06 16:27 ` [PATCH v5 11/15] test: cover subranges with present DW_AT_count attribute Sanimir Agovic
2014-02-28 17:52 ` Joel Brobecker
2014-02-06 16:27 ` Sanimir Agovic [this message]
2014-02-06 16:27 ` [PATCH v5 08/15] vla: support for DW_AT_count Sanimir Agovic
2014-02-28 16:53 ` Joel Brobecker
2014-03-12 13:51 ` Agovic, Sanimir
2014-03-13 15:36 ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 07/15] vla: print "variable length" for unresolved dynamic bounds Sanimir Agovic
2014-02-06 16:28 ` [PATCH v5 14/15] test: basic c99 vla tests for C primitives Sanimir Agovic
2014-02-28 18:04 ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 06/15] vla: update type from newly created value Sanimir Agovic
2014-02-06 16:28 ` [PATCH v5 02/15] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2014-02-06 16:28 ` [PATCH v5 01/15] refactoring: rename create_range_type to create_static_range_type Sanimir Agovic
2014-02-27 22:03 ` Joel Brobecker
2014-02-28 11:02 ` Agovic, Sanimir
2014-02-06 16:28 ` [PATCH v5 15/15] test: add mi vla test Sanimir Agovic
2014-02-28 18:07 ` Joel Brobecker
2014-03-12 12:53 ` Agovic, Sanimir
2014-02-06 16:28 ` [PATCH v5 10/15] vla: evaluate operand of sizeof if its type is a vla Sanimir Agovic
2014-02-28 17:37 ` Joel Brobecker
2014-03-19 12:55 ` Agovic, Sanimir
2014-03-19 15:12 ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 13/15] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2014-02-28 18:01 ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 05/15] vla: enable sizeof operator for indirection Sanimir Agovic
2014-02-06 16:28 ` [PATCH v5 03/15] type: add c99 variable length array support Sanimir Agovic
2014-02-28 16:27 ` Joel Brobecker
2014-04-08 6:41 ` Agovic, Sanimir
2014-04-08 12:49 ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 12/15] test: multi-dimensional c99 vla Sanimir Agovic
2014-02-28 17:58 ` Joel Brobecker
2014-02-06 16:28 ` [PATCH v5 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence Sanimir Agovic
2014-02-07 10:27 ` Joel Brobecker
2014-02-07 12:27 ` Agovic, Sanimir
2014-02-28 17:09 ` Joel Brobecker
2014-03-12 13:40 ` Agovic, Sanimir
2014-03-13 16:00 ` Joel Brobecker
2014-03-19 15:35 ` Agovic, Sanimir
2014-02-09 3:49 ` [PATCH v5 00/15] C99 variable length array support Joel Brobecker
2014-02-10 4:33 ` Joel Brobecker
2014-02-17 20:22 ` Joel Brobecker
2014-02-26 14:05 ` Joel Brobecker
2014-03-03 16:51 ` Agovic, Sanimir
2014-02-28 18:13 ` status update: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391704056-25246-5-git-send-email-sanimir.agovic@intel.com \
--to=sanimir.agovic@intel.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox