Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: pushed: [RFA 1/2] New GDB/MI command "-info-gdb-mi-command"
Date: Tue, 03 Dec 2013 04:06:00 -0000	[thread overview]
Message-ID: <20131203040608.GB3114@adacore.com> (raw)
In-Reply-To: <529C9EC1.2040607@redhat.com>

> > gdb/ChangeLog:
> > 
> >         * mi/mi-cmds.h (mi_cmd_info_gdb_mi_command): Declare.
> >         * mi/mi-cmd-info.c (mi_cmd_info_gdb_mi_command): New function.
> >         * mi/mi-cmds.c (mi_cmds): Add -info-gdb-mi-command command.
> >         * mi/mi-main.c (mi_cmd_list_features): Add "info-gdb-mi-command"
> >         field to output of "-list-features".
> > 
> >         * NEWS: Add entry for new -info-gdb-mi-command.
> > 
> > gdb/doc/ChangeLog:
> > 
> >         * gdb.texinfo (GDB/MI Miscellaneous Commands): Document
> >         the new -info-gdb-mi-command GDB/MI command.  Document
> >         the meaning of "-info-gdb-mi-command" in the output of
> >         -list-features.
> > 
> > gdb/testsuite/ChangeLog:
> > 
> >         * gdb.mi/mi-i-cmd.exp: New file.
> > 
> > Re-tested on x86_64-linux.  OK to commit?
> > 
> 
> Looks fine to me.
> 
> (I don't have a strong opinion about the dash issue.)
> 
> > +# First, verify that the debugger correctly advertises support
> > +# for the -info-gdb-mi-command command.
> > +mi_gdb_test "-list-features" \
> > +            "\\^done,features=\\\[.*\"info-gdb-mi-command\".*\\\]" \
> > +            "-list-features should include \"info-gdb-mi-command\""
> 
> Nit, I'd suggest:
> 
>            "-list-features includes \"info-gdb-mi-command\""
> 

Thanks, Pedro. The suggestion does seem better to me too, so I applied
it. Patch now in.

-- 
Joel


  reply	other threads:[~2013-12-03  4:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-10 17:16 [RFC] Add ada-exception-catchpoints to -list-features command output Joel Brobecker
2013-11-10 22:16 ` Eli Zaretskii
2013-11-12 11:25   ` Joel Brobecker
2013-11-12 16:39     ` Eli Zaretskii
2013-11-13  3:02       ` Joel Brobecker
2013-11-11 15:22 ` Tom Tromey
2013-11-12  9:18   ` Joel Brobecker
2013-11-12 12:11   ` [RFC] New GDB/MI command "-info-gdb-mi-command" Joel Brobecker
2013-11-12 17:04     ` Eli Zaretskii
2013-11-12 17:48       ` Joel Brobecker
2013-11-12 18:34         ` Eli Zaretskii
2013-11-13  3:19           ` Joel Brobecker
2013-11-12 21:17     ` André Pönitz
2013-11-13  2:47       ` Joel Brobecker
2013-11-14  0:36         ` André Pönitz
2013-11-14  9:48           ` Joel Brobecker
2013-11-14 18:31             ` André Pönitz
2013-11-14 19:03         ` Pedro Alves
2013-11-14 19:37           ` Pedro Alves
2013-11-14 20:30             ` Tom Tromey
2013-11-15  5:35               ` Joel Brobecker
2013-11-15 12:39                 ` Pedro Alves
2013-11-15 14:38                   ` Joel Brobecker
2013-11-15 14:40                     ` Pedro Alves
2013-11-18 17:12                       ` [RFA GDB/MI] Help determine if GDB/MI command exists or not Joel Brobecker
2013-11-18 17:13                         ` [RFA 1/2] New GDB/MI command "-info-gdb-mi-command" Joel Brobecker
2013-11-18 17:29                           ` Eli Zaretskii
2013-11-19  4:35                             ` Joel Brobecker
2013-11-19 16:11                               ` Eli Zaretskii
2013-12-02  3:26                               ` Joel Brobecker
2013-12-02  3:51                                 ` Eli Zaretskii
2013-12-02  4:41                                   ` Joel Brobecker
2013-12-02 14:53                               ` Pedro Alves
2013-12-03  4:06                                 ` Joel Brobecker [this message]
2013-11-18 17:21                         ` [RFA 2/2] Add "undefined-command" error code at end of ^error result Joel Brobecker
2013-11-18 17:29                           ` Eli Zaretskii
2013-11-19  6:02                             ` Joel Brobecker
2013-11-19 16:16                               ` Eli Zaretskii
2013-11-19 11:19                           ` Pedro Alves
2013-11-20  3:46                             ` Joel Brobecker
2013-12-03  4:08                               ` pushed: " Joel Brobecker
2013-11-19 15:05                         ` [RFA GDB/MI] Help determine if GDB/MI command exists or not Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131203040608.GB3114@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox