Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Add ada-exception-catchpoints to -list-features command output.
Date: Tue, 12 Nov 2013 09:18:00 -0000	[thread overview]
Message-ID: <20131112075759.GC3481@adacore.com> (raw)
In-Reply-To: <8761rzknb4.fsf@fleche.redhat.com>

> Joel> This patch adds an entry meant to help the frontend for those features.
> Joel> But looking at the way the -list-features command is designed, I am
> Joel> wondering whether this approach is going to scale well. As new commands
> Joel> and other new features or major bug fixes get in, it seems like the
> Joel> list is going to grow maybe a little beyond what's reasonable.
> 
> We could add a way to check for specific commands.  Then new commands
> would never need to be added to the feature list.

I like the idea. I need to think a bit about the actual API.
I was thinking something along the lines of:

    -info-gdb-mi-command MI_COMMAND

The first implementation would just return one field, which would
say yay or nay. But eventually, it might be nice to add other
properties, such as maybe some kind of versioning number to help
track evolution of the command, or maybe a command-specific feature
list. The latter might be less abstract/complex and extensible enough
to fit all needs.

So, for instance (if the following is valid GDB/MI syntax):

    -info-gdb-mi-command catch-load
    -^done,info={exists="true",features=['-c']}

which would tell us that the -catch-load command exists, and that
in this version of GDB, the "-c" features is supported, for instance
telling us that it's possible to add a condition to the catchpoint.

> 
> Joel> So, although this patch proposes a new field (this is the straightforward
> Joel> approach), given that all this GDB/MI work was done within the same
> Joel> release cycle, and withing a reasonable amount of time, I think it
> Joel> would be fine for everyone to use one single field in -list-features.
> 
> I think it is reasonable, too, provided that the MI docs note the
> details of what the feature means.

Of course. I will send a patch as soon as I have a moment.

-- 
Joel


  reply	other threads:[~2013-11-12  7:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-10 17:16 Joel Brobecker
2013-11-10 22:16 ` Eli Zaretskii
2013-11-12 11:25   ` Joel Brobecker
2013-11-12 16:39     ` Eli Zaretskii
2013-11-13  3:02       ` Joel Brobecker
2013-11-11 15:22 ` Tom Tromey
2013-11-12  9:18   ` Joel Brobecker [this message]
2013-11-12 12:11   ` [RFC] New GDB/MI command "-info-gdb-mi-command" Joel Brobecker
2013-11-12 17:04     ` Eli Zaretskii
2013-11-12 17:48       ` Joel Brobecker
2013-11-12 18:34         ` Eli Zaretskii
2013-11-13  3:19           ` Joel Brobecker
2013-11-12 21:17     ` André Pönitz
2013-11-13  2:47       ` Joel Brobecker
2013-11-14  0:36         ` André Pönitz
2013-11-14  9:48           ` Joel Brobecker
2013-11-14 18:31             ` André Pönitz
2013-11-14 19:03         ` Pedro Alves
2013-11-14 19:37           ` Pedro Alves
2013-11-14 20:30             ` Tom Tromey
2013-11-15  5:35               ` Joel Brobecker
2013-11-15 12:39                 ` Pedro Alves
2013-11-15 14:38                   ` Joel Brobecker
2013-11-15 14:40                     ` Pedro Alves
2013-11-18 17:12                       ` [RFA GDB/MI] Help determine if GDB/MI command exists or not Joel Brobecker
2013-11-18 17:13                         ` [RFA 1/2] New GDB/MI command "-info-gdb-mi-command" Joel Brobecker
2013-11-18 17:29                           ` Eli Zaretskii
2013-11-19  4:35                             ` Joel Brobecker
2013-11-19 16:11                               ` Eli Zaretskii
2013-12-02  3:26                               ` Joel Brobecker
2013-12-02  3:51                                 ` Eli Zaretskii
2013-12-02  4:41                                   ` Joel Brobecker
2013-12-02 14:53                               ` Pedro Alves
2013-12-03  4:06                                 ` pushed: " Joel Brobecker
2013-11-18 17:21                         ` [RFA 2/2] Add "undefined-command" error code at end of ^error result Joel Brobecker
2013-11-18 17:29                           ` Eli Zaretskii
2013-11-19  6:02                             ` Joel Brobecker
2013-11-19 16:16                               ` Eli Zaretskii
2013-11-19 11:19                           ` Pedro Alves
2013-11-20  3:46                             ` Joel Brobecker
2013-12-03  4:08                               ` pushed: " Joel Brobecker
2013-11-19 15:05                         ` [RFA GDB/MI] Help determine if GDB/MI command exists or not Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131112075759.GC3481@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox