From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30706 invoked by alias); 3 Dec 2013 04:06:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30695 invoked by uid 89); 3 Dec 2013 04:06:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_50,RDNS_NONE autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Dec 2013 04:06:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6083611684B for ; Mon, 2 Dec 2013 23:06:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ohvaDvfe47+o for ; Mon, 2 Dec 2013 23:06:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EADD0116845 for ; Mon, 2 Dec 2013 23:06:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2ED98E0833; Tue, 3 Dec 2013 08:06:08 +0400 (RET) Date: Tue, 03 Dec 2013 04:06:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: pushed: [RFA 1/2] New GDB/MI command "-info-gdb-mi-command" Message-ID: <20131203040608.GB3114@adacore.com> References: <528631F2.40408@redhat.com> <1384794719-20594-1-git-send-email-brobecker@adacore.com> <1384794719-20594-2-git-send-email-brobecker@adacore.com> <83y54lfwrm.fsf@gnu.org> <20131119041022.GF3481@adacore.com> <529C9EC1.2040607@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <529C9EC1.2040607@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-12/txt/msg00057.txt.bz2 > > gdb/ChangeLog: > > > > * mi/mi-cmds.h (mi_cmd_info_gdb_mi_command): Declare. > > * mi/mi-cmd-info.c (mi_cmd_info_gdb_mi_command): New function. > > * mi/mi-cmds.c (mi_cmds): Add -info-gdb-mi-command command. > > * mi/mi-main.c (mi_cmd_list_features): Add "info-gdb-mi-command" > > field to output of "-list-features". > > > > * NEWS: Add entry for new -info-gdb-mi-command. > > > > gdb/doc/ChangeLog: > > > > * gdb.texinfo (GDB/MI Miscellaneous Commands): Document > > the new -info-gdb-mi-command GDB/MI command. Document > > the meaning of "-info-gdb-mi-command" in the output of > > -list-features. > > > > gdb/testsuite/ChangeLog: > > > > * gdb.mi/mi-i-cmd.exp: New file. > > > > Re-tested on x86_64-linux. OK to commit? > > > > Looks fine to me. > > (I don't have a strong opinion about the dash issue.) > > > +# First, verify that the debugger correctly advertises support > > +# for the -info-gdb-mi-command command. > > +mi_gdb_test "-list-features" \ > > + "\\^done,features=\\\[.*\"info-gdb-mi-command\".*\\\]" \ > > + "-list-features should include \"info-gdb-mi-command\"" > > Nit, I'd suggest: > > "-list-features includes \"info-gdb-mi-command\"" > Thanks, Pedro. The suggestion does seem better to me too, so I applied it. Patch now in. -- Joel