[PATCH] S390: Fix undefined symbol "my_waitpid"

[PATCH] S390: Fix undefined symbol "my_waitpid"

[Andreas Arnez]

Fix the S390 build.  When linux-waitpid.o was introduced (see
http://sourceware.org/ml/gdb-patches/2013-08/msg00530.html), it was
forgotten to add it to s390.mh; so that's what this patch does.

2013-09-10  Andreas Arnez  <arnez@linux.vnet.ibm.com>

	* config/s390/s390.mh (NATDEPFILES): Add linux-waitpid.o.

diff --git a/gdb/config/s390/s390.mh b/gdb/config/s390/s390.mh
index a53835c..76d82e5 100644
--- a/gdb/config/s390/s390.mh
+++ b/gdb/config/s390/s390.mh
@@ -2,6 +2,7 @@
 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o s390-nat.o \
 	linux-thread-db.o proc-service.o \
-	linux-nat.o linux-osdata.o linux-fork.o linux-procfs.o linux-ptrace.o
+	linux-nat.o linux-osdata.o linux-fork.o linux-procfs.o linux-ptrace.o \
+	linux-waitpid.o
 NAT_CDEPS = $(srcdir)/proc-service.list
 LOADLIBES = -ldl $(RDYNAMIC)

Re: [PATCH] S390: Fix undefined symbol "my_waitpid"

[Joel Brobecker]

> Fix the S390 build.  When linux-waitpid.o was introduced (see
> http://sourceware.org/ml/gdb-patches/2013-08/msg00530.html), it was
> forgotten to add it to s390.mh; so that's what this patch does.
> 
> 2013-09-10  Andreas Arnez  <arnez@linux.vnet.ibm.com>
> 
> 	* config/s390/s390.mh (NATDEPFILES): Add linux-waitpid.o.

LGTM. Please go ahead and commit.

Thanks!
-- 
Joel

Re: [PATCH] S390: Fix undefined symbol "my_waitpid"

[Ulrich Weigand]

Andreas Arnez wrote:

> Fix the S390 build.  When linux-waitpid.o was introduced (see
> http://sourceware.org/ml/gdb-patches/2013-08/msg00530.html), it was
> forgotten to add it to s390.mh; so that's what this patch does.

This happens every now and then, most likely because the s390
files do not have -linux- in their name, unlike all the other
Linux target files.

At some point, it would probably be good to change this.  (Maybe
once we're off CVS and can actually do renames without losing
history ...)

> 2013-09-10  Andreas Arnez  <arnez@linux.vnet.ibm.com>
> 
> 	* config/s390/s390.mh (NATDEPFILES): Add linux-waitpid.o.

I've checked this in now.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com

Re: [PATCH] S390: Fix undefined symbol "my_waitpid"

[Andreas Arnez]

"Ulrich Weigand" <uweigand@de.ibm.com> writes:

> At some point, it would probably be good to change this.  (Maybe
> once we're off CVS and can actually do renames without losing
> history ...)

Right, that's probably a good idea.  I'll keep that in mind after source
control has moved to GIT.

Re: [PATCH] S390: Fix undefined symbol "my_waitpid"

[Pedro Alves]

On 09/10/2013 04:07 PM, Ulrich Weigand wrote:

>> Fix the S390 build.  When linux-waitpid.o was introduced (see
>> http://sourceware.org/ml/gdb-patches/2013-08/msg00530.html), it was
>> forgotten to add it to s390.mh; so that's what this patch does.
> 
> This happens every now and then, most likely because the s390
> files do not have -linux- in their name, unlike all the other
> Linux target files.

Eh, twice in a couple weeks.  A similar thing happened with the
cris-linux port just recently:

  https://sourceware.org/ml/gdb-patches/2013-09/msg00076.html

Because it didn't have a -linux- file.  We ended up
adding a cris-linux-tdep.c file.

> At some point, it would probably be good to change this.  (Maybe
> once we're off CVS and can actually do renames without losing
> history ...)

If the cvs rm + cvs add are done in the same commit, AFAIK,
git will identify it as a rename, so we could do it now even, IMO.

-- 
Pedro Alves