From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8939 invoked by alias); 18 Sep 2013 18:39:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8926 invoked by uid 89); 18 Sep 2013 18:39:29 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2013 18:39:29 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8IIdLth001872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Sep 2013 14:39:22 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8IIdJk2031840; Wed, 18 Sep 2013 14:39:20 -0400 Message-ID: <5239F357.2080906@redhat.com> Date: Wed, 18 Sep 2013 18:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Ulrich Weigand CC: Andreas Arnez , gdb-patches@sourceware.org, Ulrich.Weigand@de.ibm.com, Luis Machado Subject: Re: [PATCH] S390: Fix undefined symbol "my_waitpid" References: <201309101507.r8AF7tHq012141@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201309101507.r8AF7tHq012141@d06av02.portsmouth.uk.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-09/txt/msg00619.txt.bz2 On 09/10/2013 04:07 PM, Ulrich Weigand wrote: >> Fix the S390 build. When linux-waitpid.o was introduced (see >> http://sourceware.org/ml/gdb-patches/2013-08/msg00530.html), it was >> forgotten to add it to s390.mh; so that's what this patch does. > > This happens every now and then, most likely because the s390 > files do not have -linux- in their name, unlike all the other > Linux target files. Eh, twice in a couple weeks. A similar thing happened with the cris-linux port just recently: https://sourceware.org/ml/gdb-patches/2013-09/msg00076.html Because it didn't have a -linux- file. We ended up adding a cris-linux-tdep.c file. > At some point, it would probably be good to change this. (Maybe > once we're off CVS and can actually do renames without losing > history ...) If the cvs rm + cvs add are done in the same commit, AFAIK, git will identify it as a rename, so we could do it now even, IMO. -- Pedro Alves