From: Pedro Alves <palves@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>,
gdb-patches@sourceware.org, Ulrich.Weigand@de.ibm.com,
Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH] S390: Fix undefined symbol "my_waitpid"
Date: Wed, 18 Sep 2013 18:39:00 -0000 [thread overview]
Message-ID: <5239F357.2080906@redhat.com> (raw)
In-Reply-To: <201309101507.r8AF7tHq012141@d06av02.portsmouth.uk.ibm.com>
On 09/10/2013 04:07 PM, Ulrich Weigand wrote:
>> Fix the S390 build. When linux-waitpid.o was introduced (see
>> http://sourceware.org/ml/gdb-patches/2013-08/msg00530.html), it was
>> forgotten to add it to s390.mh; so that's what this patch does.
>
> This happens every now and then, most likely because the s390
> files do not have -linux- in their name, unlike all the other
> Linux target files.
Eh, twice in a couple weeks. A similar thing happened with the
cris-linux port just recently:
https://sourceware.org/ml/gdb-patches/2013-09/msg00076.html
Because it didn't have a -linux- file. We ended up
adding a cris-linux-tdep.c file.
> At some point, it would probably be good to change this. (Maybe
> once we're off CVS and can actually do renames without losing
> history ...)
If the cvs rm + cvs add are done in the same commit, AFAIK,
git will identify it as a rename, so we could do it now even, IMO.
--
Pedro Alves
prev parent reply other threads:[~2013-09-18 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 12:02 Andreas Arnez
2013-09-10 12:31 ` Joel Brobecker
2013-09-10 15:08 ` Ulrich Weigand
2013-09-11 11:42 ` Andreas Arnez
2013-09-18 18:39 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5239F357.2080906@redhat.com \
--to=palves@redhat.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox