[PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[Hui Zhu]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

Hi,

This patch fix http://sourceware.org/bugzilla/show_bug.cgi?id=15186

Add a fflash to make the output of dprintf can be shown at once.

Please help me review it.

Thanks,
Hui

2013-04-19  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15186

	* ax.c (ax_printf): Add fflush.

[-- Attachment #2: dprintf-agent-fflash.txt --]
[-- Type: text/plain, Size: 247 bytes --]

--- a/gdb/gdbserver/ax.c
+++ b/gdb/gdbserver/ax.c
@@ -905,6 +905,7 @@ ax_printf (CORE_ADDR fn, CORE_ADDR chan,
     }
 
   free_format_pieces (fpieces);
+  fflush (stdout);
 }
 
 /* The agent expression evaluator, as specified by the GDB docs. It

Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[Tom Tromey]

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> Please help me review it.

Hui> 2013-04-19  Hui Zhu  <hui@codesourcery.com>
Hui> 	PR gdb/15186
Hui> 	* ax.c (ax_printf): Add fflush.

I think this could use a test case.
And it seems to me if you want the behavior to be the same for all
styles of dprintf, then it should test all variants.

Tom

Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[Hui Zhu]

On Sat, Apr 20, 2013 at 12:55 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> Please help me review it.
>
> Hui> 2013-04-19  Hui Zhu  <hui@codesourcery.com>
> Hui>    PR gdb/15186
> Hui>    * ax.c (ax_printf): Add fflush.
>
> I think this could use a test case.
> And it seems to me if you want the behavior to be the same for all
> styles of dprintf, then it should test all variants.
>
> Tom

I want to do it.
But I am not sure DejaGnu can test the output of gdbserver.  And I
think this is why "dprintf.exp" doesn't test the print output of
agent.
Could you give me a example for it?

Thanks,
Hui

Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[Tom Tromey]

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> I want to do it.
Hui> But I am not sure DejaGnu can test the output of gdbserver.  And I
Hui> think this is why "dprintf.exp" doesn't test the print output of
Hui> agent.
Hui> Could you give me a example for it?

Ok, I think I see.
The patch is ok.

Tom

Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[Hui Zhu]

On Thu, Apr 25, 2013 at 4:36 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> I want to do it.
> Hui> But I am not sure DejaGnu can test the output of gdbserver.  And I
> Hui> think this is why "dprintf.exp" doesn't test the print output of
> Hui> agent.
> Hui> Could you give me a example for it?
>
> Ok, I think I see.
> The patch is ok.

Checked in to http://www.sourceware.org/ml/gdb-cvs/2013-04/msg00234.html
Can I commit this patch to 7.6 branch?

Thanks,
Hui

>
> Tom

Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[Joel Brobecker]

> Checked in to http://www.sourceware.org/ml/gdb-cvs/2013-04/msg00234.html
> Can I commit this patch to 7.6 branch?

Sure, ok for 7.6.

-- 
Joel

Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly

[Hui Zhu]

On Thu, Apr 25, 2013 at 2:51 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Checked in to http://www.sourceware.org/ml/gdb-cvs/2013-04/msg00234.html
>> Can I commit this patch to 7.6 branch?
>
> Sure, ok for 7.6.

Commit to http://www.sourceware.org/ml/gdb-cvs/2013-04/msg00237.html

Thanks,
Hui

>
> --
> Joel