From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4596 invoked by alias); 21 Apr 2013 02:18:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4583 invoked by uid 89); 21 Apr 2013 02:18:52 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-oa0-f53.google.com (HELO mail-oa0-f53.google.com) (209.85.219.53) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 21 Apr 2013 02:18:52 +0000 Received: by mail-oa0-f53.google.com with SMTP id m6so4872374oag.40 for ; Sat, 20 Apr 2013 19:18:50 -0700 (PDT) X-Received: by 10.60.34.202 with SMTP id b10mr7509860oej.119.1366510730684; Sat, 20 Apr 2013 19:18:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.13.133 with HTTP; Sat, 20 Apr 2013 19:18:10 -0700 (PDT) In-Reply-To: <877gjywjdf.fsf@fleche.redhat.com> References: <877gjywjdf.fsf@fleche.redhat.com> From: Hui Zhu Date: Mon, 22 Apr 2013 07:34:00 -0000 Message-ID: Subject: Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly To: Tom Tromey Cc: gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-04/txt/msg00643.txt.bz2 On Sat, Apr 20, 2013 at 12:55 AM, Tom Tromey wrote: >>>>>> "Hui" == Hui Zhu writes: > > Hui> Please help me review it. > > Hui> 2013-04-19 Hui Zhu > Hui> PR gdb/15186 > Hui> * ax.c (ax_printf): Add fflush. > > I think this could use a test case. > And it seems to me if you want the behavior to be the same for all > styles of dprintf, then it should test all variants. > > Tom I want to do it. But I am not sure DejaGnu can test the output of gdbserver. And I think this is why "dprintf.exp" doesn't test the print output of agent. Could you give me a example for it? Thanks, Hui