From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix bug 15186 Agent style dprintf does not buffer output properly
Date: Fri, 19 Apr 2013 18:47:00 -0000 [thread overview]
Message-ID: <877gjywjdf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon2yzXniBG81PLqQf-m3Ctj0_fku0t-8TDumMnsppnXPgw@mail.gmail.com> (Hui Zhu's message of "Fri, 19 Apr 2013 18:58:22 +0800")
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> Please help me review it.
Hui> 2013-04-19 Hui Zhu <hui@codesourcery.com>
Hui> PR gdb/15186
Hui> * ax.c (ax_printf): Add fflush.
I think this could use a test case.
And it seems to me if you want the behavior to be the same for all
styles of dprintf, then it should test all variants.
Tom
next prev parent reply other threads:[~2013-04-19 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 14:32 Hui Zhu
2013-04-19 18:47 ` Tom Tromey [this message]
2013-04-22 7:34 ` Hui Zhu
2013-04-25 6:53 ` Tom Tromey
2013-04-25 13:53 ` Hui Zhu
2013-04-25 14:19 ` Joel Brobecker
2013-04-25 17:25 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gjywjdf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox