Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling

[Corinna Vinschen <vinschen@redhat.com>]

On Mar 27 13:22, Eli Zaretskii wrote:
> > Date: Wed, 27 Mar 2013 12:13:01 +0100
> > From: Corinna Vinschen <vinschen@redhat.com>
> > 
> > > > ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string':
> > > > ../../src/gdb/windows-nat.c:993:16: erreur: assignment makes pointer from integer without a cast
> > > 
> > > Right.  But IMO the casts here are dubious to begin with.  strtoull
> > > produces a 64-bit value; casting it to a 32-bit uintptr_t might shut
> > 
> > This is really no problem.  We know what value comes out of Cygwin.
> > It's a 32 bit pointer value on 32 bit and a 64 bit value on 64 bit,
> > so the cast is always right.
> 
> It may be right, but clean it isn't.  I guess we will have to
> disagree.
> 
> > Please stop CCing me.
> 
> It's not me, it's the "reply" function of my mailer.  If you don't
> want to get a copy, please set up your mail headers to cause that.

I do.  I always set a Reply-To.  There's also a "Reply to mailing list"
function in some MUAs.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat