From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6705 invoked by alias); 27 Mar 2013 11:28:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6371 invoked by uid 89); 27 Mar 2013 11:27:57 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 11:27:55 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 352EB520652; Wed, 27 Mar 2013 12:27:52 +0100 (CET) Date: Wed, 27 Mar 2013 16:45:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling Message-ID: <20130327112752.GA30133@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20130319151436.GB20727@calimero.vinschen.de> <20130319212554.GE4506@adacore.com> <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr> <83y5d9xrqt.fsf@gnu.org> <005501ce2ac8$ae830150$0b8903f0$%muller@ics-cnrs.unistra.fr> <83obe5xgq2.fsf@gnu.org> <20130327111301.GA28863@calimero.vinschen.de> <83k3otxf20.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <83k3otxf20.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-03/txt/msg01017.txt.bz2 On Mar 27 13:22, Eli Zaretskii wrote: > > Date: Wed, 27 Mar 2013 12:13:01 +0100 > > From: Corinna Vinschen > > > > > > ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string': > > > > ../../src/gdb/windows-nat.c:993:16: erreur: assignment makes pointer from integer without a cast > > > > > > Right. But IMO the casts here are dubious to begin with. strtoull > > > produces a 64-bit value; casting it to a 32-bit uintptr_t might shut > > > > This is really no problem. We know what value comes out of Cygwin. > > It's a 32 bit pointer value on 32 bit and a 64 bit value on 64 bit, > > so the cast is always right. > > It may be right, but clean it isn't. I guess we will have to > disagree. > > > Please stop CCing me. > > It's not me, it's the "reply" function of my mailer. If you don't > want to get a copy, please set up your mail headers to cause that. I do. I always set a Reply-To. There's also a "Reply to mailing list" function in some MUAs. Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat