From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] windows-nat.c: Fix offset problem in signal string handling
Date: Wed, 20 Mar 2013 02:25:00 -0000 [thread overview]
Message-ID: <20130319212554.GE4506@adacore.com> (raw)
In-Reply-To: <20130319151436.GB20727@calimero.vinschen.de>
> Alternatively the call to string_to_core_addr could be replaced with a
> call to `strtoull (p, NULL, 0)'. Since this code is only supported on
> Cygwin, it's safe to assume that the strtoull function exists.
I would go for that option, mostly because you already use strtol
to parse the beginning of that string...
> Version 2:
>
> * windows-nat.c (handle_output_debug_string): Replace call
> to string_to_core_addr with call to strtoull.
>
> Index: windows-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/windows-nat.c,v
> retrieving revision 1.242
> diff -u -p -r1.242 windows-nat.c
> --- windows-nat.c 19 Mar 2013 15:06:26 -0000 1.242
> +++ windows-nat.c 19 Mar 2013 15:13:10 -0000
> @@ -978,7 +978,7 @@ handle_output_debug_string (struct targe
> retval = strtoul (p, &p, 0);
> if (!retval)
> retval = main_thread_id;
> - else if ((x = (LPCVOID) string_to_core_addr (p))
> + else if ((x = (LPCVOID) strtoull (p, NULL, 0))
> && ReadProcessMemory (current_process_handle, x,
> &saved_context,
> __COPY_CONTEXT_SIZE, &n)
--
Joel
next prev parent reply other threads:[~2013-03-19 21:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 16:24 Corinna Vinschen
2013-03-20 2:25 ` Joel Brobecker [this message]
2013-03-20 9:36 ` Corinna Vinschen
2013-03-27 4:59 ` [RFA] Fix cygwin32 failure introduced by " Pierre Muller
2013-03-27 7:53 ` Joel Brobecker
2013-03-27 10:47 ` Corinna Vinschen
2013-03-27 11:13 ` Pierre Muller
[not found] ` <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr>
2013-03-27 10:02 ` Eli Zaretskii
2013-03-27 10:53 ` Corinna Vinschen
2013-03-27 10:59 ` Pierre Muller
[not found] ` <005501ce2ac8$ae830150$0b8903f0$%muller@ics-cnrs.unistra.fr>
2013-03-27 12:24 ` Eli Zaretskii
2013-03-27 14:39 ` Eli Zaretskii
2013-03-27 14:50 ` Eli Zaretskii
2013-03-27 15:23 ` Corinna Vinschen
2013-03-27 16:06 ` Eli Zaretskii
2013-03-27 16:45 ` Corinna Vinschen
2013-03-27 16:58 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319212554.GE4506@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox