From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: RE: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling
Date: Wed, 27 Mar 2013 11:13:00 -0000 [thread overview]
Message-ID: <005801ce2acb$5780f580$0682e080$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20130327084722.GA22857@calimero.vinschen.de>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Corinna Vinschen
> Envoyé : mercredi 27 mars 2013 09:47
> À : gdb-patches@sourceware.org
> Objet : Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c:
> Fix offset problem in signal string handling
>
> On Mar 26 16:43, Joel Brobecker wrote:
> > > cc1: warnings being treated as errors
> > > ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string':
> > > ../../src/gdb/windows-nat.c:993:18: error: cast to pointer from integer
> of
> > > different size
> > > Makefile:972: recipe for target `windows-nat.o' failed
> > > make: *** [windows-nat.o] Error 1
> > > make: Leaving directory `/usr/local/src/gdbcvs/build-norm/gdb'
> > >
> > > This failure can be fixed by this simple patch, which should
> > > not affect the unreleased 64-bit Cygwin, a confirmation
> > > by Corinna would be nice on this part...
> > >
> > >
> > > ChangeLog entry:
> > >
> > > 2013-03-26 Pierre Muller <muller@sourceware.org>
> > >
> > > * windows-nat.c (handle_output_debug_string): Avoid typecast
> > > from integer of different size warning.
> >
> > This looks about right to me. Let's wait for Corinna to confirm
> > that it's OK with her too and commit.
>
> Yes, that looks good to me. Thanks for fixing this for 32 bit.
> Please apply.
Thank you, patch applied to main.
Pierre Muller
next prev parent reply other threads:[~2013-03-27 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 16:24 Corinna Vinschen
2013-03-20 2:25 ` Joel Brobecker
2013-03-20 9:36 ` Corinna Vinschen
2013-03-27 4:59 ` [RFA] Fix cygwin32 failure introduced by " Pierre Muller
2013-03-27 7:53 ` Joel Brobecker
2013-03-27 10:47 ` Corinna Vinschen
2013-03-27 11:13 ` Pierre Muller [this message]
[not found] ` <000101ce2a6b$8c855a60$a5900f20$%muller@ics-cnrs.unistra.fr>
2013-03-27 10:02 ` Eli Zaretskii
2013-03-27 10:53 ` Corinna Vinschen
2013-03-27 10:59 ` Pierre Muller
[not found] ` <005501ce2ac8$ae830150$0b8903f0$%muller@ics-cnrs.unistra.fr>
2013-03-27 12:24 ` Eli Zaretskii
2013-03-27 14:39 ` Eli Zaretskii
2013-03-27 14:50 ` Eli Zaretskii
2013-03-27 15:23 ` Corinna Vinschen
2013-03-27 16:06 ` Eli Zaretskii
2013-03-27 16:45 ` Corinna Vinschen
2013-03-27 16:58 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005801ce2acb$5780f580$0682e080$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox