Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Print MI fullname even for non-existing files
Date: Mon, 17 Dec 2012 18:36:00 -0000	[thread overview]
Message-ID: <20121217183600.GB14232@host2.jankratochvil.net> (raw)
In-Reply-To: <50CF4467.5090603@broadcom.com>

On Mon, 17 Dec 2012 17:12:23 +0100, Andrew Burgess wrote:
> On 17/12/2012 3:58 PM, Jan Kratochvil wrote:
> > Is there a serious reason why fullname was suppressed for non-existing files?
> 
> I added the fullname field in source.c, there was no good reason then
> for dropping the field if we got NULL back except that (1) it matched
> the behaviour in stack.c, and (2) if we got null back then I'd have just
> left the field empty which didn't feel very useful.

Thanks; although I was more curious why symtab_to_fullname itself returns NULL
for non-existing files, ignoring possibly present symtab->dirname.


> > While it breaks MI compatibility in some way I find it an acceptable change.
> 
> I agree.

Thanks for this confirmation.


Jan


  reply	other threads:[~2012-12-17 18:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 15:59 Jan Kratochvil
2012-12-17 16:13 ` Andrew Burgess
2012-12-17 18:36   ` Jan Kratochvil [this message]
2012-12-17 16:33 ` Eli Zaretskii
2012-12-17 16:36   ` Jan Kratochvil
2012-12-17 18:33 ` Tom Tromey
2012-12-17 18:37   ` Jan Kratochvil
2012-12-17 18:41     ` Tom Tromey
2012-12-17 18:59       ` Jan Kratochvil
2012-12-28  0:17         ` Edjunior Barbosa Machado
2012-12-28  9:09           ` [commit] " Jan Kratochvil
2012-12-20 14:33   ` Marc Khouzam
2012-12-25  8:04     ` [commit] " Jan Kratochvil
2013-01-03 15:38       ` Marc Khouzam
2013-01-03 15:44         ` Jan Kratochvil
2013-01-03 16:04           ` Tom Tromey
2013-01-03 16:57             ` Joel Brobecker
2013-04-02 16:24 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121217183600.GB14232@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=aburgess@broadcom.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox