From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13251 invoked by alias); 17 Dec 2012 18:36:12 -0000 Received: (qmail 13024 invoked by uid 22791); 17 Dec 2012 18:36:10 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Dec 2012 18:36:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBHIa5Im019737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 17 Dec 2012 13:36:05 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBHIa1J3032298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 17 Dec 2012 13:36:04 -0500 Date: Mon, 17 Dec 2012 18:36:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Print MI fullname even for non-existing files Message-ID: <20121217183600.GB14232@host2.jankratochvil.net> References: <20121217155859.GA8029@host2.jankratochvil.net> <50CF4467.5090603@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50CF4467.5090603@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00585.txt.bz2 On Mon, 17 Dec 2012 17:12:23 +0100, Andrew Burgess wrote: > On 17/12/2012 3:58 PM, Jan Kratochvil wrote: > > Is there a serious reason why fullname was suppressed for non-existing files? > > I added the fullname field in source.c, there was no good reason then > for dropping the field if we got NULL back except that (1) it matched > the behaviour in stack.c, and (2) if we got null back then I'd have just > left the field empty which didn't feel very useful. Thanks; although I was more curious why symtab_to_fullname itself returns NULL for non-existing files, ignoring possibly present symtab->dirname. > > While it breaks MI compatibility in some way I find it an acceptable change. > > I agree. Thanks for this confirmation. Jan