From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: [commit] [rfc] Print MI fullname even for non-existing files
Date: Fri, 28 Dec 2012 09:09:00 -0000 [thread overview]
Message-ID: <20121228090735.GA15391@host2.jankratochvil.net> (raw)
In-Reply-To: <50DCE502.5050700@linux.vnet.ibm.com>
On Fri, 28 Dec 2012 01:17:06 +0100, Edjunior Barbosa Machado wrote:
> This seem to be due to a strcmp with a null string 'symtab->fullname' in:
>
> if (FILENAME_CMP (symtab->fullname, symtab_to_fullname (s)) != 0)
>
> With the patch below, this problem is fixed and gdb.base/list.exp no longer
> crashes gdb. Ok?
Thanks for the bugreport. I have checked in an equivalent fix below.
Jan
http://sourceware.org/ml/gdb-cvs/2012-12/msg00192.html
--- src/gdb/ChangeLog 2012/12/25 17:27:47 1.14982
+++ src/gdb/ChangeLog 2012/12/28 09:05:39 1.14983
@@ -1,3 +1,8 @@
+2012-12-28 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * symtab.c (find_line_symtab): Call symtab_to_fullname instead of
+ accessing FULLNAME directly.
+
2012-12-25 Sergio Durigan Junior <sergiodj@redhat.com>
* frv-linux-tdep.c (frv_linux_pc_in_sigtramp): Fix typo.
--- src/gdb/symtab.c 2012/12/25 08:03:31 1.333
+++ src/gdb/symtab.c 2012/12/28 09:05:40 1.334
@@ -2554,7 +2554,8 @@
if (FILENAME_CMP (symtab->filename, s->filename) != 0)
continue;
- if (FILENAME_CMP (symtab->fullname, symtab_to_fullname (s)) != 0)
+ if (FILENAME_CMP (symtab_to_fullname (symtab),
+ symtab_to_fullname (s)) != 0)
continue;
l = LINETABLE (s);
ind = find_line_common (l, line, &exact, 0);
next prev parent reply other threads:[~2012-12-28 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 15:59 Jan Kratochvil
2012-12-17 16:13 ` Andrew Burgess
2012-12-17 18:36 ` Jan Kratochvil
2012-12-17 16:33 ` Eli Zaretskii
2012-12-17 16:36 ` Jan Kratochvil
2012-12-17 18:33 ` Tom Tromey
2012-12-17 18:37 ` Jan Kratochvil
2012-12-17 18:41 ` Tom Tromey
2012-12-17 18:59 ` Jan Kratochvil
2012-12-28 0:17 ` Edjunior Barbosa Machado
2012-12-28 9:09 ` Jan Kratochvil [this message]
2012-12-20 14:33 ` Marc Khouzam
2012-12-25 8:04 ` [commit] " Jan Kratochvil
2013-01-03 15:38 ` Marc Khouzam
2013-01-03 15:44 ` Jan Kratochvil
2013-01-03 16:04 ` Tom Tromey
2013-01-03 16:57 ` Joel Brobecker
2013-04-02 16:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121228090735.GA15391@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox