From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>, Matt Rice <ratmice@gmail.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: [commit] [doc patchv2] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
Date: Sun, 16 Dec 2012 19:00:00 -0000 [thread overview]
Message-ID: <20121216190044.GB25317@host2.jankratochvil.net> (raw)
In-Reply-To: <20121211202228.GA12984@host2.jankratochvil.net>
On Tue, 11 Dec 2012 21:22:28 +0100, Jan Kratochvil wrote:
> gdb/doc/
> 2012-12-11 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdbint.texinfo (Coding Standards) (C Usage): New rule for 0 vs. NULL.
>
> gdb/
> 2012-12-11 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup.
> * skip.c (skip_function_command, skip_file_command, skip_info): Remove
> unused forward declarations.
> (skip_file_command): Make variables symtab and filename targets const.
> Use proper 0 vs. NULL constant everywhere.
> (skip_function_command): Use proper 0 vs. NULL constant everywhere.
> Include empty line after declarations. Use GNU spacing in a comment.
> Do not use strlen for end of string check.
> (skip_info): Use proper 0 vs. NULL constant everywhere. Add column 5
> comments.
> (skip_enable_command, skip_disable_command, skip_delete_command)
> (add_skiplist_entry): Use proper 0 vs. NULL constant everywhere.
> (function_pc_is_marked_for_skip): Make variable filename target const.
> Use proper 0 vs. NULL constant everywhere. Fix GNU non-compliant
> comment formatting.
> (skip_re_set): Add empty line after function comment. Use proper 0 vs.
> NULL constant everywhere. Include empty line after declarations. Make
> variable symtab target const. Do not use strlen for end of string
> check.
Checked in:
http://sourceware.org/ml/gdb-cvs/2012-12/msg00117.html
Thanks,
Jan
prev parent reply other threads:[~2012-12-16 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 18:42 [doc patch] " Jan Kratochvil
2012-12-11 1:54 ` Joel Brobecker
2012-12-11 6:07 ` Jan Kratochvil
2012-12-11 6:51 ` Jan Kratochvil
2012-12-11 10:22 ` Pedro Alves
2012-12-11 12:01 ` Joel Brobecker
2012-12-11 20:22 ` [doc patchv2] " Jan Kratochvil
2012-12-11 20:39 ` Eli Zaretskii
2012-12-11 20:43 ` Jan Kratochvil
2012-12-12 4:29 ` Joel Brobecker
2012-12-16 19:00 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121216190044.GB25317@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=ratmice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox