Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Matt Rice <ratmice@gmail.com>,
	       Pedro Alves <palves@redhat.com>
Subject: Re: [doc patch] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
Date: Tue, 11 Dec 2012 06:51:00 -0000	[thread overview]
Message-ID: <20121211065127.GA10815@host2.jankratochvil.net> (raw)
In-Reply-To: <20121211060641.GA7775@host2.jankratochvil.net>

On Tue, 11 Dec 2012 07:06:41 +0100, Jan Kratochvil wrote:
> OK         if (first)
> not great  if (!first)
> OK         if (first == NULL)
> OK         if (first != NULL)
> BAD        if (first == 0)
> BAD        if (first != 0)

BTW c++ -Wzero-as-null-pointer-constant warns only about the last two cases.


Jan


  reply	other threads:[~2012-12-11  6:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10 18:42 Jan Kratochvil
2012-12-11  1:54 ` Joel Brobecker
2012-12-11  6:07   ` Jan Kratochvil
2012-12-11  6:51     ` Jan Kratochvil [this message]
2012-12-11 10:22     ` Pedro Alves
2012-12-11 12:01       ` Joel Brobecker
2012-12-11 20:22         ` [doc patchv2] " Jan Kratochvil
2012-12-11 20:39           ` Eli Zaretskii
2012-12-11 20:43             ` Jan Kratochvil
2012-12-12  4:29               ` Joel Brobecker
2012-12-16 19:00           ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121211065127.GA10815@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=ratmice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox