From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96834-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26024 invoked by alias); 11 Dec 2012 06:51:45 -0000
Received: (qmail 26013 invoked by uid 22791); 11 Dec 2012 06:51:44 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 06:51:36 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBB6pXhV015080	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 11 Dec 2012 01:51:33 -0500
Received: from host2.jankratochvil.net (ovpn-116-35.ams2.redhat.com [10.36.116.35])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBB6pSZp014082	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 11 Dec 2012 01:51:31 -0500
Date: Tue, 11 Dec 2012 06:51:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Matt Rice <ratmice@gmail.com>,        Pedro Alves <palves@redhat.com>
Subject: Re: [doc patch] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
Message-ID: <20121211065127.GA10815@host2.jankratochvil.net>
References: <20121210184220.GA29321@host2.jankratochvil.net> <20121211015343.GM31477@adacore.com> <20121211060641.GA7775@host2.jankratochvil.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121211060641.GA7775@host2.jankratochvil.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00307.txt.bz2

On Tue, 11 Dec 2012 07:06:41 +0100, Jan Kratochvil wrote:
> OK         if (first)
> not great  if (!first)
> OK         if (first == NULL)
> OK         if (first != NULL)
> BAD        if (first == 0)
> BAD        if (first != 0)

BTW c++ -Wzero-as-null-pointer-constant warns only about the last two cases.


Jan