Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: brobecker@adacore.com, palves@redhat.com,
	gdb-patches@sourceware.org,        ratmice@gmail.com
Subject: Re: [doc patchv2] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c
Date: Tue, 11 Dec 2012 20:43:00 -0000	[thread overview]
Message-ID: <20121211204341.GA15341@host2.jankratochvil.net> (raw)
In-Reply-To: <83vcc88gt5.fsf@gnu.org>

On Tue, 11 Dec 2012 21:39:02 +0100, Eli Zaretskii wrote:
> Okayed -- under protest, because I happen to think that
> 
>   if (!pointer)
> 
> is perfectly valid C.

This (pointer) and (!pointer) rule is very commonly violated in current GDB.

Originally I did not want to go so far with these new rules but why not.


Thanks,
Jan


  reply	other threads:[~2012-12-11 20:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10 18:42 [doc patch] " Jan Kratochvil
2012-12-11  1:54 ` Joel Brobecker
2012-12-11  6:07   ` Jan Kratochvil
2012-12-11  6:51     ` Jan Kratochvil
2012-12-11 10:22     ` Pedro Alves
2012-12-11 12:01       ` Joel Brobecker
2012-12-11 20:22         ` [doc patchv2] " Jan Kratochvil
2012-12-11 20:39           ` Eli Zaretskii
2012-12-11 20:43             ` Jan Kratochvil [this message]
2012-12-12  4:29               ` Joel Brobecker
2012-12-16 19:00           ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121211204341.GA15341@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=ratmice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox