From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19470 invoked by alias); 16 Dec 2012 19:00:58 -0000 Received: (qmail 19460 invoked by uid 22791); 16 Dec 2012 19:00:57 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 16 Dec 2012 19:00:53 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBGJ0oVR030295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 16 Dec 2012 14:00:50 -0500 Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBGJ0jPJ009027 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 16 Dec 2012 14:00:48 -0500 Date: Sun, 16 Dec 2012 19:00:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Pedro Alves , Matt Rice , Joel Brobecker Subject: [commit] [doc patchv2] coding style: 0 vs. NULL + [patch] Code cleanup: skip.c Message-ID: <20121216190044.GB25317@host2.jankratochvil.net> References: <20121210184220.GA29321@host2.jankratochvil.net> <20121211015343.GM31477@adacore.com> <20121211060641.GA7775@host2.jankratochvil.net> <50C7093F.5000600@redhat.com> <20121211120057.GO31477@adacore.com> <20121211202228.GA12984@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121211202228.GA12984@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00531.txt.bz2 On Tue, 11 Dec 2012 21:22:28 +0100, Jan Kratochvil wrote: > gdb/doc/ > 2012-12-11 Jan Kratochvil > > * gdbint.texinfo (Coding Standards) (C Usage): New rule for 0 vs. NULL. > > gdb/ > 2012-12-11 Jan Kratochvil > > Code cleanup. > * skip.c (skip_function_command, skip_file_command, skip_info): Remove > unused forward declarations. > (skip_file_command): Make variables symtab and filename targets const. > Use proper 0 vs. NULL constant everywhere. > (skip_function_command): Use proper 0 vs. NULL constant everywhere. > Include empty line after declarations. Use GNU spacing in a comment. > Do not use strlen for end of string check. > (skip_info): Use proper 0 vs. NULL constant everywhere. Add column 5 > comments. > (skip_enable_command, skip_disable_command, skip_delete_command) > (add_skiplist_entry): Use proper 0 vs. NULL constant everywhere. > (function_pc_is_marked_for_skip): Make variable filename target const. > Use proper 0 vs. NULL constant everywhere. Fix GNU non-compliant > comment formatting. > (skip_re_set): Add empty line after function comment. Use proper 0 vs. > NULL constant everywhere. Include empty line after declarations. Make > variable symtab target const. Do not use strlen for end of string > check. Checked in: http://sourceware.org/ml/gdb-cvs/2012-12/msg00117.html Thanks, Jan