Re: [PATCH 1/2] Put a NT_PSTATUS note on solaris cores.

[Joel Brobecker <brobecker@adacore.com>]

> You're doing the right test.  The issue is that core_pid_to_str
> calls into the gdbarch_core_pid_to_str, and that isn't expecting
> to be passed a "process pid" instead of an "LWP pid".
> 
> Could you try this one when you have a chance?  This is rebased on
> top of current mainline, so it restores the elfcore_write_pstatus
> call that the Unixware-excise patch removed.  I made sure it builds with
> --enable-targets=all.

Nice detective work :)

    (gdb) core core.26444
    [New LWP 1]
    Core was generated by `/[...]/simple_main'.
    Program terminated with signal 5, Trace/breakpoint trap.
    #0  simple_main () at simple_main.adb:4
    4           simple.test_simple;
    (gdb) info inferiors
      Num  Description       Executable
    * 1    process 26444     /[...]/simple_main

And with an older core file, since your patch handles it too:

    (gdb) info inferiors
      Num  Description       Executable
    * 1    <core>            /[...]/simple_main

I tested the patch against our testsuite again, no regression either.
So it looks all good to go!

Cheers,
-- 
Joel