From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] solib-svr4.c: Remove old SCO-related code.
Date: Thu, 06 Dec 2012 17:37:00 -0000 [thread overview]
Message-ID: <20121206173653.15629.99432.stgit@brno.lan> (raw)
Support for SCO has been removed in 2007, by:
http://sourceware.org/ml/gdb-patches/2007-03/msg00327.html
But this bit in svr4_solib_create_inferior_hook remains left behind.
Let me know if I missed anything, like a supported non-SCO target actually
defining _SCO_DS too, though that sounds very unlikely to me.
I notice that unixware support has also been dropped in that same 2007
change, so it seems like all the #ifdef UNIXWARE checks in procfs.c could
be removed too, along with the "*-*-unixware*" check in configure.ac.
2012-12-06 Pedro Alves <palves@redhat.com>
* solib-svr4.c (svr4_solib_create_inferior_hook) [_SCO_DS]: Remove
dead SCO code, and adjust function description comment.
---
gdb/solib-svr4.c | 41 +----------------------------------------
1 file changed, 1 insertion(+), 40 deletions(-)
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 02e45a3..316c1b7 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -2212,25 +2212,11 @@ svr4_relocate_main_executable (void)
This function is responsible for discovering those names and
addresses, and saving sufficient information about them to allow
- their symbols to be read at a later time.
-
- FIXME
-
- Between enable_break() and disable_break(), this code does not
- properly handle hitting breakpoints which the user might have
- set in the startup code or in the dynamic linker itself. Proper
- handling will probably have to wait until the implementation is
- changed to use the "breakpoint handler function" method.
-
- Also, what if child has exit()ed? Must exit loop somehow. */
+ their symbols to be read at a later time. */
static void
svr4_solib_create_inferior_hook (int from_tty)
{
-#if defined(_SCO_DS)
- struct inferior *inf;
- struct thread_info *tp;
-#endif /* defined(_SCO_DS) */
struct svr4_info *info;
info = get_svr4_info ();
@@ -2248,31 +2234,6 @@ svr4_solib_create_inferior_hook (int from_tty)
if (!enable_break (info, from_tty))
return;
-
-#if defined(_SCO_DS)
- /* SCO needs the loop below, other systems should be using the
- special shared library breakpoints and the shared library breakpoint
- service routine.
-
- Now run the target. It will eventually hit the breakpoint, at
- which point all of the libraries will have been mapped in and we
- can go groveling around in the dynamic linker structures to find
- out what we need to know about them. */
-
- inf = current_inferior ();
- tp = inferior_thread ();
-
- clear_proceed_status ();
- inf->control.stop_soon = STOP_QUIETLY;
- tp->suspend.stop_signal = GDB_SIGNAL_0;
- do
- {
- target_resume (pid_to_ptid (-1), 0, tp->suspend.stop_signal);
- wait_for_inferior ();
- }
- while (tp->suspend.stop_signal != GDB_SIGNAL_TRAP);
- inf->control.stop_soon = NO_STOP_QUIETLY;
-#endif /* defined(_SCO_DS) */
}
static void
next reply other threads:[~2012-12-06 17:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 17:37 Pedro Alves [this message]
2012-12-10 16:44 ` Pedro Alves
2012-12-10 18:02 ` [PATCH 1/2] Put a NT_PSTATUS note on solaris cores Pedro Alves
2012-12-11 3:04 ` Joel Brobecker
2012-12-11 12:22 ` Pedro Alves
2012-12-11 15:12 ` Joel Brobecker
2012-12-11 15:16 ` Mark Kettenis
2012-12-11 16:45 ` Pedro Alves
2012-12-10 18:04 ` [PATCH 2/2] Remove all traces of Unixware Pedro Alves
2012-12-10 19:24 ` Tom Tromey
2012-12-11 2:57 ` Joel Brobecker
2012-12-11 11:37 ` Pedro Alves
2012-12-11 12:46 ` Eli Zaretskii
2012-12-11 4:20 ` Yao Qi
2012-12-11 10:59 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206173653.15629.99432.stgit@brno.lan \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox