From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3791 invoked by alias); 11 Dec 2012 15:12:10 -0000 Received: (qmail 3757 invoked by uid 22791); 11 Dec 2012 15:12:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 15:11:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2A5902E420; Tue, 11 Dec 2012 10:11:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5r8FHGL1TLz5; Tue, 11 Dec 2012 10:11:58 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B4D502E2FD; Tue, 11 Dec 2012 10:11:57 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 898E7C3B05; Tue, 11 Dec 2012 19:11:36 +0400 (RET) Date: Tue, 11 Dec 2012 15:12:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Put a NT_PSTATUS note on solaris cores. Message-ID: <20121211151136.GQ31477@adacore.com> References: <50C6115C.4090509@redhat.com> <20121210180216.3932.48633.stgit@brno.lan> <20121211030352.GB13565@adacore.com> <50C72573.5060305@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C72573.5060305@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00334.txt.bz2 > You're doing the right test. The issue is that core_pid_to_str > calls into the gdbarch_core_pid_to_str, and that isn't expecting > to be passed a "process pid" instead of an "LWP pid". > > Could you try this one when you have a chance? This is rebased on > top of current mainline, so it restores the elfcore_write_pstatus > call that the Unixware-excise patch removed. I made sure it builds with > --enable-targets=all. Nice detective work :) (gdb) core core.26444 [New LWP 1] Core was generated by `/[...]/simple_main'. Program terminated with signal 5, Trace/breakpoint trap. #0 simple_main () at simple_main.adb:4 4 simple.test_simple; (gdb) info inferiors Num Description Executable * 1 process 26444 /[...]/simple_main And with an older core file, since your patch handles it too: (gdb) info inferiors Num Description Executable * 1 /[...]/simple_main I tested the patch against our testsuite again, no regression either. So it looks all good to go! Cheers, -- Joel