New ARI warning Fri Nov 16 01:56:44 UTC 2012

New ARI warning Fri Nov 16 01:56:44 UTC 2012

[GDB Administrator]

137a138
> gdb/common/gdb_stat.h:23: regression: stat.h: Do not include stat.h or sys/stat.h, instead include gdb_stat.h
gdb/common/gdb_stat.h:23:#include <sys/stat.h>
138a140,141
> gdb/common/gdb_wait.h:23: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
gdb/common/gdb_wait.h:23:#include <sys/wait.h>  
> gdb/common/gdb_wait.h:26: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
gdb/common/gdb_wait.h:26:#include <wait.h>  
140d142
< gdb/common/linux-osdata.c:29: regression: stat.h: Do not include stat.h or sys/stat.h, instead include gdb_stat.h
gdb/common/linux-osdata.c:29:#include <sys/stat.h>
170d171
< gdb/common/linux-ptrace.c:60: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
gdb/common/linux-ptrace.c:60:#include <sys/wait.h>
276,277d276
< gdb/dwarf2read.c:8613: regression: xasprintf: Do not use xasprintf(), instead use xstrprintf
gdb/dwarf2read.c:8613:  xasprintf (&virtual_dwo_name, ',
< gdb/dwarf2read.c:8985: regression: xasprintf: Do not use xasprintf(), instead use xstrprintf
gdb/dwarf2read.c:8985:  xasprintf (&dwp_name, ', dwarf2_per_objfile->objfile->name);

Re: New ARI warning Fri Nov 16 01:56:44 UTC 2012

[Joel Brobecker]

> > gdb/common/gdb_stat.h:23: regression: stat.h: Do not include stat.h or sys/stat.h, instead include gdb_stat.h
> gdb/common/gdb_stat.h:23:#include <sys/stat.h>
> 138a140,141
> > gdb/common/gdb_wait.h:23: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
> gdb/common/gdb_wait.h:23:#include <sys/wait.h>  
> > gdb/common/gdb_wait.h:26: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
> gdb/common/gdb_wait.h:26:#include <wait.h>  

I expect that these are going to become OBE pretty soon, so nothing
to be done. But there might be other cases like this (Eg: abort) where
the few uses are correct and expected.  For those, they should be
explicitly marked as OK via an /* ARI */ comment to make sure the ARI
does not complain about them.

-- 
Joel

RE: New ARI warning Fri Nov 16 01:56:44 UTC 2012

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : vendredi 16 novembre 2012 03:20
> À : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Fri Nov 16 01:56:44 UTC 2012
> 
> > > gdb/common/gdb_stat.h:23: regression: stat.h: Do not include stat.h or
> sys/stat.h, instead include gdb_stat.h
> > gdb/common/gdb_stat.h:23:#include <sys/stat.h>
> > 138a140,141
> > > gdb/common/gdb_wait.h:23: regression: wait.h: Do not include wait.h or
> sys/wait.h, instead include gdb_wait.h
> > gdb/common/gdb_wait.h:23:#include <sys/wait.h>
> > > gdb/common/gdb_wait.h:26: regression: wait.h: Do not include wait.h or
> sys/wait.h, instead include gdb_wait.h
> > gdb/common/gdb_wait.h:26:#include <wait.h>

  This email was generated by the script 
that is on the gdb server in $HOME/ss directory and
generates:
http://sourceware.org/gdb/current/ari/
  
  The ARI situation improved, but this is only visible on the 
other web page
http://sourceware.org/gdb/current/ari/test
that uses the in CVS scripts.

  Should I switch to sending emails from these scripts?
The current problem is that branch doesn't have contrib./ari directory
yet, so I can only do this for trunk...

Pierre Muller
as ARI maintainer
 
PS: in
http://sourceware.org/gdb/current/ari/test
on the strerror problem is left :)

Re: New ARI warning Fri Nov 16 01:56:44 UTC 2012

[Joel Brobecker]

> Should I switch to sending emails from these scripts?
> The current problem is that branch doesn't have contrib./ari directory
> yet, so I can only do this for trunk...

I would defer to you over what makes most sense for you.

As for the branch, I think adding them to the release branch would be
zero risk. If that makes it easier for you, you can add them there
as well.

-- 
Joel

RE: New ARI warning Fri Nov 16 01:56:44 UTC 2012

[Pierre Muller]

  Hi Joel,
  now that 7.5.1 is out,
could I insert contrib/ari into branch?
  
What about the rule of adding something to NEWS...
I am not sure an agreement was already reached on
your proposal...

Pierre Muller
as ARI maintainer

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : lundi 19 novembre 2012 23:27
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Fri Nov 16 01:56:44 UTC 2012
> 
> > Should I switch to sending emails from these scripts?
> > The current problem is that branch doesn't have contrib./ari directory
> > yet, so I can only do this for trunk...
> 
> I would defer to you over what makes most sense for you.
> 
> As for the branch, I think adding them to the release branch would be
> zero risk. If that makes it easier for you, you can add them there
> as well.
> 
> --
> Joel

Re: New ARI warning Fri Nov 16 01:56:44 UTC 2012

[Joel Brobecker]

>   Hi Joel,
>   now that 7.5.1 is out,
> could I insert contrib/ari into branch?

Yes, of course, please go ahead. I assume that you know that there
will likely not be another release off that branch - so it must be
for technical convenience, is that rigth?

> What about the rule of adding something to NEWS...
> I am not sure an agreement was already reached on
> your proposal...

There is no precise agreement yet - some interesting ideas have
been discussed. But I didn't push, because there is no need to
have a rule until we release 7.6. I will bring it up again when
it becomes necessary.

-- 
Joel

RE: New ARI warning Fri Nov 16 01:56:44 UTC 2012

[Pierre Muller]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé : mardi 11 décembre 2012 14:12
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Fri Nov 16 01:56:44 UTC 2012
> 
> >   Hi Joel,
> >   now that 7.5.1 is out,
> > could I insert contrib/ari into branch?
> 
> Yes, of course, please go ahead.

Thanks, I committed the patch
adding current CVS trunk files to gdb_7_5-branch
http://sourceware.org/ml/gdb-cvs/2012-12/msg00056.html

ChangeLog entry:

2012-12-11  Pierre Muller  <muller@ics.u-strasbg.fr>

	Incorporate ARI web page generator into gdb_7_5-branch.
	* contrib/ari/create-web-ari-in-src.sh: New file.
	* contrib/ari/gdb_ari.sh: New file.
	* contrib/ari/gdb_find.sh: New file.
	* contrib/ari/update-web-ari.sh: New file.
> I assume that you know that there
> will likely not be another release off that branch - so it must be
> for technical convenience, is that rigth?

 Yes, this will trigger the generation of web pages
for both trunk and branch, and will facilitate
moving from the old ARI scripts in ss CVS repository to
the new ARI pages, generated by the in CVS scripts.

Pierre Muller
as ARI maintainer