Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "André Pönitz" <andre.poenitz@mathematik.tu-chemnitz.de>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Display full file path in MI style disassembly listing
Date: Thu, 18 Oct 2012 18:06:00 -0000	[thread overview]
Message-ID: <20121018180600.GA3368@klara.mpi.htwm.de> (raw)
In-Reply-To: <507FD732.8010400@redhat.com>

On Thu, Oct 18, 2012 at 11:17:22AM +0100, Pedro Alves wrote:
> On 10/18/2012 10:48 AM, Andrew Burgess wrote:
> 
> >>> I think we should
> >>> output a "fullname" field for MI, like we do for breakpoints.
> > 
> > I would be happy to take this approach as a compromise.
> 
> IMO, it's not really a compromise.  It's all about giving all the data
> to the frontend, so it can do whatever it pleases.
> 
>  - the file path as recorded in the compilation.  This is useful to have
>    so the user can identify issues with fullpath mappings.
>  - the file path gdb thinks that maps to in the filesystem, using the current
>    settings of "directory/set directories/etc".

I'd personally also call it a proper solution, not a compromise.

> I'd even argue that the backtrace path in question should not change the "file"
> field in MI, but instead it would add a new field to the output, if that's
> also useful for MI.

From an MI consumer's point of view anything that provides the raw data and 
a "best effort interpretation" at the same time is perfect. Not providing
"raw data" leaves no room for fixups in case the "cooked" version is "wrong",
not providing the "cooked" version leaves the consumer with re-implementing
the "cooking", often enough without access to helpful auxilliary infomation.

Andre'


  reply	other threads:[~2012-10-18 18:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04 16:09 Andrew Burgess
2012-10-05 12:44 ` Jan Kratochvil
2012-10-07 14:28   ` Andrew Burgess
2012-10-07 14:34     ` Jan Kratochvil
2012-10-07 15:16       ` Joel Brobecker
2012-10-17 17:20         ` Tom Tromey
2012-10-17 18:13   ` Pedro Alves
2012-10-18  6:48     ` Jan Kratochvil
2012-10-18  9:49       ` Andrew Burgess
2012-10-18 10:17         ` Pedro Alves
2012-10-18 18:06           ` André Pönitz [this message]
2012-10-18 13:45         ` Jan Kratochvil
2012-10-17 17:16 ` Tom Tromey
2012-10-18  9:34   ` Andrew Burgess
2012-10-18 13:45     ` Jan Kratochvil
2012-10-17 18:25 ` Pedro Alves
2012-10-22 21:26 ` Add fullname field in disassembly output (Was Re: [PATCH] Display full file path in MI style disassembly listing) Andrew Burgess
2012-10-31 14:54   ` Add fullname field in disassembly output Pedro Alves
2012-11-02 10:59     ` Andrew Burgess
2012-11-02 15:32       ` Pedro Alves
2012-11-06 12:14         ` Andrew Burgess
2012-11-06 17:44           ` Eli Zaretskii
2012-11-07 15:08             ` Andrew Burgess
2012-11-07 15:48               ` Pedro Alves
2012-11-08 21:30                 ` Tom Tromey
2012-11-09 13:26                   ` Andrew Burgess
2012-11-03  7:42       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121018180600.GA3368@klara.mpi.htwm.de \
    --to=andre.poenitz@mathematik.tu-chemnitz.de \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox