From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Add fullname field in disassembly output
Date: Fri, 02 Nov 2012 15:32:00 -0000 [thread overview]
Message-ID: <5093E786.2090909@redhat.com> (raw)
In-Reply-To: <5093A785.3060103@broadcom.com>
On 11/02/2012 10:59 AM, Andrew Burgess wrote:
> On 31/10/2012 2:53 PM, Pedro Alves wrote:
>
>>> Ok to commit?
>>
>> Not yet, sorry. This new field needs to be documented in the manual, and mentioned in NEWS.
>
> Sorry, I should have realised I'd need to do these things.
>
> Latest version of patch, includes fullname field, test
> updates, noted in documentation and in NEWS file.
>
> Is this Ok?
The code looks good to me, thanks.
But it looks strange to me that NEWS has more detail on the new output
than the docs. IMO, it would be good if, e.g., something around the
part that reads:
The output for each instruction is composed of four fields:
was updated to reflect the new field. The short examples alone
don't explain what the field is.
In any case, Eli will give you the final word on the docs bits.
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2012-11-02 15:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 16:09 [PATCH] Display full file path in MI style disassembly listing Andrew Burgess
2012-10-05 12:44 ` Jan Kratochvil
2012-10-07 14:28 ` Andrew Burgess
2012-10-07 14:34 ` Jan Kratochvil
2012-10-07 15:16 ` Joel Brobecker
2012-10-17 17:20 ` Tom Tromey
2012-10-17 18:13 ` Pedro Alves
2012-10-18 6:48 ` Jan Kratochvil
2012-10-18 9:49 ` Andrew Burgess
2012-10-18 10:17 ` Pedro Alves
2012-10-18 18:06 ` André Pönitz
2012-10-18 13:45 ` Jan Kratochvil
2012-10-17 17:16 ` Tom Tromey
2012-10-18 9:34 ` Andrew Burgess
2012-10-18 13:45 ` Jan Kratochvil
2012-10-17 18:25 ` Pedro Alves
2012-10-22 21:26 ` Add fullname field in disassembly output (Was Re: [PATCH] Display full file path in MI style disassembly listing) Andrew Burgess
2012-10-31 14:54 ` Add fullname field in disassembly output Pedro Alves
2012-11-02 10:59 ` Andrew Burgess
2012-11-02 15:32 ` Pedro Alves [this message]
2012-11-06 12:14 ` Andrew Burgess
2012-11-06 17:44 ` Eli Zaretskii
2012-11-07 15:08 ` Andrew Burgess
2012-11-07 15:48 ` Pedro Alves
2012-11-08 21:30 ` Tom Tromey
2012-11-09 13:26 ` Andrew Burgess
2012-11-03 7:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093E786.2090909@redhat.com \
--to=palves@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox