From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: Tom Tromey <tromey@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Display full file path in MI style disassembly listing
Date: Thu, 18 Oct 2012 13:45:00 -0000 [thread overview]
Message-ID: <20121018134049.GA30950@host2.jankratochvil.net> (raw)
In-Reply-To: <507FCD17.30003@broadcom.com>
On Thu, 18 Oct 2012 11:34:15 +0200, Andrew Burgess wrote:
> On 17/10/2012 6:15 PM, Tom Tromey wrote:
> >>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
> > It isn't obvious to me that this only applies to the MI case.
> > Can you explain that?
>
> You are correct, and my subject line is miss-leading. It is possible to
> hit this code from cli gdb, but I believe this only happens if we fail
> to open the file.
This discussion is difficult without backing the patch with a testcase, at
least for the cases you want to change (cases you do not want to change would
be also nice to check but I understand it may be too broad to cover).
Otherwise the "sleeping" patch I mentioned I would like to push again later
may likely break this new functionality without noticing it.
Thanks,
Jan
next prev parent reply other threads:[~2012-10-18 13:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 16:09 Andrew Burgess
2012-10-05 12:44 ` Jan Kratochvil
2012-10-07 14:28 ` Andrew Burgess
2012-10-07 14:34 ` Jan Kratochvil
2012-10-07 15:16 ` Joel Brobecker
2012-10-17 17:20 ` Tom Tromey
2012-10-17 18:13 ` Pedro Alves
2012-10-18 6:48 ` Jan Kratochvil
2012-10-18 9:49 ` Andrew Burgess
2012-10-18 10:17 ` Pedro Alves
2012-10-18 18:06 ` André Pönitz
2012-10-18 13:45 ` Jan Kratochvil
2012-10-17 17:16 ` Tom Tromey
2012-10-18 9:34 ` Andrew Burgess
2012-10-18 13:45 ` Jan Kratochvil [this message]
2012-10-17 18:25 ` Pedro Alves
2012-10-22 21:26 ` Add fullname field in disassembly output (Was Re: [PATCH] Display full file path in MI style disassembly listing) Andrew Burgess
2012-10-31 14:54 ` Add fullname field in disassembly output Pedro Alves
2012-11-02 10:59 ` Andrew Burgess
2012-11-02 15:32 ` Pedro Alves
2012-11-06 12:14 ` Andrew Burgess
2012-11-06 17:44 ` Eli Zaretskii
2012-11-07 15:08 ` Andrew Burgess
2012-11-07 15:48 ` Pedro Alves
2012-11-08 21:30 ` Tom Tromey
2012-11-09 13:26 ` Andrew Burgess
2012-11-03 7:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018134049.GA30950@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox