From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7219 invoked by alias); 18 Oct 2012 18:06:09 -0000 Received: (qmail 7207 invoked by uid 22791); 18 Oct 2012 18:06:08 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cora.hrz.tu-chemnitz.de (HELO cora.hrz.tu-chemnitz.de) (134.109.228.40) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Oct 2012 18:06:03 +0000 Received: from 91-66-51-36-dynip.superkabel.de ([91.66.51.36] helo=localhost) by cora.hrz.tu-chemnitz.de with esmtpsa (TLSv1:DHE-RSA-AES128-SHA:128) (Exim 4.80) (envelope-from ) id 1TOuTp-00064w-Tl; Thu, 18 Oct 2012 20:06:02 +0200 Date: Thu, 18 Oct 2012 18:06:00 -0000 From: =?iso-8859-1?Q?Andr=E9_P=F6nitz?= To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Display full file path in MI style disassembly listing Message-ID: <20121018180600.GA3368@klara.mpi.htwm.de> References: <506DB4B8.5030001@broadcom.com> <20121005124353.GA22997@host2.jankratochvil.net> <507EF554.4080404@redhat.com> <20121018064825.GA15668@host2.jankratochvil.net> <507FD088.4030101@broadcom.com> <507FD732.8010400@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <507FD732.8010400@redhat.com> X-purgate: clean X-purgate-type: clean X-purgate-ID: 154106::1350583562-00000CD1-EFA27584/0-0/0-0 X-Scan-AV: cora.hrz.tu-chemnitz.de;2012-10-18 20:06:02;bcb4dd3273d552ce183660a5414b4a7c X-Scan-SA: cora.hrz.tu-chemnitz.de;2012-10-18 20:06:02;c71ce2d12a24fb4d98c9c033949d6379 X-Spam-Score: -1.0 (-) X-Spam-Report: --- Textanalyse SpamAssassin 3.3.1 (-1.0 Punkte) Fragen an/questions to: Postmaster TU Chemnitz * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP --- Ende Textanalyse X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00337.txt.bz2 On Thu, Oct 18, 2012 at 11:17:22AM +0100, Pedro Alves wrote: > On 10/18/2012 10:48 AM, Andrew Burgess wrote: > > >>> I think we should > >>> output a "fullname" field for MI, like we do for breakpoints. > > > > I would be happy to take this approach as a compromise. > > IMO, it's not really a compromise. It's all about giving all the data > to the frontend, so it can do whatever it pleases. > > - the file path as recorded in the compilation. This is useful to have > so the user can identify issues with fullpath mappings. > - the file path gdb thinks that maps to in the filesystem, using the current > settings of "directory/set directories/etc". I'd personally also call it a proper solution, not a compromise. > I'd even argue that the backtrace path in question should not change the "file" > field in MI, but instead it would add a new field to the output, if that's > also useful for MI. >From an MI consumer's point of view anything that provides the raw data and a "best effort interpretation" at the same time is perfect. Not providing "raw data" leaves no room for fixups in case the "cooked" version is "wrong", not providing the "cooked" version leaves the consumer with re-implementing the "cooking", often enough without access to helpful auxilliary infomation. Andre'