Re: [RFA 3/4] Improved linker-debugger interface

[Gary Benson <gbenson@redhat.com>]

Jan Kratochvil wrote:
> On Thu, 12 Jul 2012 14:35:54 +0200, Gary Benson wrote:
> > --- a/gdb/probe.h
> > +++ b/gdb/probe.h
> > @@ -210,6 +210,17 @@ extern void info_probes_for_ops (char *arg, int from_tty,
> >  
> >  extern struct cmd_list_element **info_probes_cmdlist_get (void);
> >  
> > +/* Return the argument count of the specified probe.  */
> 
> /* OBJFILE must be known to have probes support.  */
> 
> > +
> > +extern unsigned get_probe_argument_count (struct objfile *objfile,
> > +					  struct probe *probe);
> > +
> > +/* Evaluate argument N of the specified probe.  */
> 
> /* OBJFILE must be known to have probes support.  N must be between
>    0 inclusive and get_probe_argument_count exclusive.  */
[snip]
> > +struct value *
> > +evaluate_probe_argument (struct objfile *objfile, struct probe *probe,
> > +			 unsigned n)
> > +{
> > +  gdb_assert (objfile->sf && objfile->sf->sym_probe_fns);
> > +
> > +  return objfile->sf->sym_probe_fns->sym_evaluate_probe_argument (objfile,
> > +								  probe,
> > +								  n);
> 
> probe and n can be on single line, it is 76 columns [yes, it is copy-paste].
[snip]
> It is pre-approved but please do not check it in without any use, only with
> some other patch depending on it.

Thank you for the review.  I have made these changes (and updated the
patch with Sergio's recent changes) here:

  http://www.cygwin.com/ml/gdb-patches/2012-07/msg00332.html

Does the pre-approval still count, or do the changes for Sergio's
stuff warrant another review?

Cheers,
Gary
  
-- 
http://gbenson.net/