From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12094 invoked by alias); 19 Jul 2012 14:36:52 -0000 Received: (qmail 12007 invoked by uid 22791); 19 Jul 2012 14:36:51 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,SPF_FAIL,TW_BJ X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jul 2012 14:36:37 +0000 Date: Thu, 19 Jul 2012 14:36:00 -0000 From: Gary Benson To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFA 3/4] Improved linker-debugger interface Message-ID: <20120719143634.GB25093@redhat.com> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20120712123406.GA29236@redhat.com> <20120712123554.GD29236@redhat.com> <20120717215641.GA10049@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120717215641.GA10049@host2.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00338.txt.bz2 Jan Kratochvil wrote: > On Thu, 12 Jul 2012 14:35:54 +0200, Gary Benson wrote: > > --- a/gdb/probe.h > > +++ b/gdb/probe.h > > @@ -210,6 +210,17 @@ extern void info_probes_for_ops (char *arg, int from_tty, > > > > extern struct cmd_list_element **info_probes_cmdlist_get (void); > > > > +/* Return the argument count of the specified probe. */ > > /* OBJFILE must be known to have probes support. */ > > > + > > +extern unsigned get_probe_argument_count (struct objfile *objfile, > > + struct probe *probe); > > + > > +/* Evaluate argument N of the specified probe. */ > > /* OBJFILE must be known to have probes support. N must be between > 0 inclusive and get_probe_argument_count exclusive. */ [snip] > > +struct value * > > +evaluate_probe_argument (struct objfile *objfile, struct probe *probe, > > + unsigned n) > > +{ > > + gdb_assert (objfile->sf && objfile->sf->sym_probe_fns); > > + > > + return objfile->sf->sym_probe_fns->sym_evaluate_probe_argument (objfile, > > + probe, > > + n); > > probe and n can be on single line, it is 76 columns [yes, it is copy-paste]. [snip] > It is pre-approved but please do not check it in without any use, only with > some other patch depending on it. Thank you for the review. I have made these changes (and updated the patch with Sergio's recent changes) here: http://www.cygwin.com/ml/gdb-patches/2012-07/msg00332.html Does the pre-approval still count, or do the changes for Sergio's stuff warrant another review? Cheers, Gary -- http://gbenson.net/