[PATCH] Trivial: Remove unused variable in c_printstr

[PATCH] Trivial: Remove unused variable in c_printstr

[Siddhesh Poyarekar]

Hi,

Here's a trivial patch that removes an unused variable WIDTH from
c_printstr.

Regards,
Siddhesh

gdb/ChangeLog:

2012-07-04  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* c-lang.c (c_printstr): Remove ununsed variable WIDTH.


diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b9e1f62..2d4f0a4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2012-06-28  Siddhesh Poyarekar  <siddhesh@redhat.com>
+
+	* c-lang.c (c_printstr): Remove ununsed variable WIDTH.
+
 2012-06-28  Doug Evans  <dje@google.com>
 
 	* dwarf2read.c (get_cu_length): New function.
diff --git a/gdb/c-lang.c b/gdb/c-lang.c
index 28dce8d..b5135d5 100644
--- a/gdb/c-lang.c
+++ b/gdb/c-lang.c
@@ -202,7 +202,6 @@ c_printstr (struct ui_file *stream, struct type *type,
   unsigned int things_printed = 0;
   int in_quotes = 0;
   int need_comma = 0;
-  int width = TYPE_LENGTH (type);
   struct obstack wchar_buf, output;
   struct cleanup *cleanup;
   struct wchar_iterator *iter;

Re: [PATCH] Trivial: Remove unused variable in c_printstr

[Siddhesh Poyarekar]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

On Wed, 4 Jul 2012 13:03:57 +0530, Siddhesh wrote:
> Here's a trivial patch that removes an unused variable WIDTH from
> c_printstr.
> 

Ugh, sorry, I didn't remove the ChangeLog hunk from my diff. Here it is
attached now. Also fixed typo in the ChangeLog.

Regards,
Siddhesh

gdb/ChangeLog:

2012-07-04  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* c-lang.c (c_printstr): Remove unused variable WIDTH.

[-- Attachment #2: gdb-unused.patch --]
[-- Type: text/x-patch, Size: 397 bytes --]

diff --git a/gdb/c-lang.c b/gdb/c-lang.c
index 28dce8d..b5135d5 100644
--- a/gdb/c-lang.c
+++ b/gdb/c-lang.c
@@ -202,7 +202,6 @@ c_printstr (struct ui_file *stream, struct type *type,
   unsigned int things_printed = 0;
   int in_quotes = 0;
   int need_comma = 0;
-  int width = TYPE_LENGTH (type);
   struct obstack wchar_buf, output;
   struct cleanup *cleanup;
   struct wchar_iterator *iter;

Re: [PATCH] Trivial: Remove unused variable in c_printstr

[Jan Kratochvil]

Hi Siddhesh,

On Wed, 04 Jul 2012 09:40:22 +0200, Siddhesh Poyarekar wrote:
> Ugh, sorry, I didn't remove the ChangeLog hunk from my diff. Here it is
> attached now. Also fixed typo in the ChangeLog.
[...]
> 	* c-lang.c (c_printstr): Remove unused variable WIDTH.

this patch is both pre-approved and also obvious, your work is also covered by
Red Hat FSF contract, could you file write-after-approval request?
	http://sourceware.org/cgi-bin/pdw/ps_form.cgi


Thanks,
Jan

Re: [PATCH] Trivial: Remove unused variable in c_printstr

[Siddhesh Poyarekar]

On Wed, 4 Jul 2012 21:59:53 +0200, Jan wrote:
> this patch is both pre-approved and also obvious, your work is also
> covered by Red Hat FSF contract, could you file write-after-approval
> request? http://sourceware.org/cgi-bin/pdw/ps_form.cgi
> 

Thanks, applied to add gdb access to my sourceware account:

http://sourceware.org/ml/overseers/2012-q3/msg00004.html

Regards,
Siddhesh

Re: [PATCH] Trivial: Remove unused variable in c_printstr

[Siddhesh Poyarekar]

On Wed, 4 Jul 2012 21:59:53 +0200, Jan wrote:
> On Wed, 04 Jul 2012 09:40:22 +0200, Siddhesh Poyarekar wrote:
> > Ugh, sorry, I didn't remove the ChangeLog hunk from my diff. Here
> > it is attached now. Also fixed typo in the ChangeLog.
> [...]
> > 	* c-lang.c (c_printstr): Remove unused variable WIDTH.
> 
> this patch is both pre-approved and also obvious, your work is also
> covered by Red Hat FSF contract, could you file write-after-approval
> request? http://sourceware.org/cgi-bin/pdw/ps_form.cgi
> 

Checked in:

http://sourceware.org/ml/gdb-cvs/2012-07/msg00045.html

Regards,
Siddhesh