From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15681 invoked by alias); 4 Jul 2012 07:40:31 -0000 Received: (qmail 15530 invoked by uid 22791); 4 Jul 2012 07:40:29 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MAY_BE_FORGED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Jul 2012 07:40:16 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q647eGBC024518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 4 Jul 2012 03:40:16 -0400 Received: from spoyarek (dhcp223-8.pnq.redhat.com [10.65.223.8] (may be forged)) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q647eEMa003539 for ; Wed, 4 Jul 2012 03:40:15 -0400 Date: Wed, 04 Jul 2012 07:40:00 -0000 From: Siddhesh Poyarekar To: gdb-patches@sourceware.org Subject: Re: [PATCH] Trivial: Remove unused variable in c_printstr Message-ID: <20120704131022.5cf91770@spoyarek> In-Reply-To: <20120704130357.0826b3ec@spoyarek> References: <20120704130357.0826b3ec@spoyarek> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/iDWXxAWMrH0UzK29mlnmPPh" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00051.txt.bz2 --MP_/iDWXxAWMrH0UzK29mlnmPPh Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 404 On Wed, 4 Jul 2012 13:03:57 +0530, Siddhesh wrote: > Here's a trivial patch that removes an unused variable WIDTH from > c_printstr. > Ugh, sorry, I didn't remove the ChangeLog hunk from my diff. Here it is attached now. Also fixed typo in the ChangeLog. Regards, Siddhesh gdb/ChangeLog: 2012-07-04 Siddhesh Poyarekar * c-lang.c (c_printstr): Remove unused variable WIDTH. --MP_/iDWXxAWMrH0UzK29mlnmPPh Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=gdb-unused.patch Content-length: 397 diff --git a/gdb/c-lang.c b/gdb/c-lang.c index 28dce8d..b5135d5 100644 --- a/gdb/c-lang.c +++ b/gdb/c-lang.c @@ -202,7 +202,6 @@ c_printstr (struct ui_file *stream, struct type *type, unsigned int things_printed = 0; int in_quotes = 0; int need_comma = 0; - int width = TYPE_LENGTH (type); struct obstack wchar_buf, output; struct cleanup *cleanup; struct wchar_iterator *iter; --MP_/iDWXxAWMrH0UzK29mlnmPPh--