From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22348 invoked by alias); 4 Jul 2012 20:00:16 -0000 Received: (qmail 22331 invoked by uid 22791); 4 Jul 2012 20:00:15 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Jul 2012 19:59:57 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q64JxviU006398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 4 Jul 2012 15:59:57 -0400 Received: from host2.jankratochvil.net (ovpn-116-32.ams2.redhat.com [10.36.116.32]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q64Jxrvo032168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 4 Jul 2012 15:59:56 -0400 Date: Wed, 04 Jul 2012 20:00:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Trivial: Remove unused variable in c_printstr Message-ID: <20120704195953.GA27907@host2.jankratochvil.net> References: <20120704130357.0826b3ec@spoyarek> <20120704131022.5cf91770@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120704131022.5cf91770@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00062.txt.bz2 Hi Siddhesh, On Wed, 04 Jul 2012 09:40:22 +0200, Siddhesh Poyarekar wrote: > Ugh, sorry, I didn't remove the ChangeLog hunk from my diff. Here it is > attached now. Also fixed typo in the ChangeLog. [...] > * c-lang.c (c_printstr): Remove unused variable WIDTH. this patch is both pre-approved and also obvious, your work is also covered by Red Hat FSF contract, could you file write-after-approval request? http://sourceware.org/cgi-bin/pdw/ps_form.cgi Thanks, Jan