* Re: [patch][sim] Fix microblaze sim build [not found] <CABu31nMez5xQ1mqwDUALJSNqvUmQo4sz2aniGK08qibTaksReg@mail.gmail.com> @ 2012-06-06 15:06 ` Michael Eager 2012-06-06 18:13 ` Mike Frysinger 0 siblings, 1 reply; 4+ messages in thread From: Michael Eager @ 2012-06-06 15:06 UTC (permalink / raw) To: Steven Bosscher; +Cc: binutils, gdb-patches On 06/06/2012 04:10 AM, Steven Bosscher wrote: > Hello, > > I needed the attached patch to build the microblaze sim. > Without the patch, bfd.h gives an #error that config.h should be > included before it. > > Could you please see if this is OK, and commit it if so? Yes, I noticed this yesterday. Committed: 2012-06-06 Michael Eager <eager@eagercon.com> * microblaze/interp.c (config.h): Add #include. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch][sim] Fix microblaze sim build 2012-06-06 15:06 ` [patch][sim] Fix microblaze sim build Michael Eager @ 2012-06-06 18:13 ` Mike Frysinger 2012-06-06 21:50 ` Michael Eager 0 siblings, 1 reply; 4+ messages in thread From: Mike Frysinger @ 2012-06-06 18:13 UTC (permalink / raw) To: binutils; +Cc: Michael Eager, Steven Bosscher, gdb-patches [-- Attachment #1: Type: Text/Plain, Size: 600 bytes --] On Wednesday 06 June 2012 11:05:30 Michael Eager wrote: > On 06/06/2012 04:10 AM, Steven Bosscher wrote: > > Hello, > > > > I needed the attached patch to build the microblaze sim. > > Without the patch, bfd.h gives an #error that config.h should be > > included before it. > > > > Could you please see if this is OK, and commit it if so? > > Yes, I noticed this yesterday. > > Committed: > > 2012-06-06 Michael Eager <eager@eagercon.com> > > * microblaze/interp.c (config.h): Add #include. config.h should generally be the first header included, not like the 6th -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch][sim] Fix microblaze sim build 2012-06-06 18:13 ` Mike Frysinger @ 2012-06-06 21:50 ` Michael Eager 2012-06-07 1:37 ` Mike Frysinger 0 siblings, 1 reply; 4+ messages in thread From: Michael Eager @ 2012-06-06 21:50 UTC (permalink / raw) To: Mike Frysinger; +Cc: binutils, Michael Eager, Steven Bosscher, gdb-patches On 06/06/2012 11:13 AM, Mike Frysinger wrote: > On Wednesday 06 June 2012 11:05:30 Michael Eager wrote: >> On 06/06/2012 04:10 AM, Steven Bosscher wrote: >>> Hello, >>> >>> I needed the attached patch to build the microblaze sim. >>> Without the patch, bfd.h gives an #error that config.h should be >>> included before it. >>> >>> Could you please see if this is OK, and commit it if so? >> >> Yes, I noticed this yesterday. >> >> Committed: >> >> 2012-06-06 Michael Eager<eager@eagercon.com> >> >> * microblaze/interp.c (config.h): Add #include. > > config.h should generally be the first header included, not like the 6th > -mike Moved to the top. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch][sim] Fix microblaze sim build 2012-06-06 21:50 ` Michael Eager @ 2012-06-07 1:37 ` Mike Frysinger 0 siblings, 0 replies; 4+ messages in thread From: Mike Frysinger @ 2012-06-07 1:37 UTC (permalink / raw) To: Michael Eager; +Cc: binutils, Michael Eager, Steven Bosscher, gdb-patches [-- Attachment #1: Type: Text/Plain, Size: 793 bytes --] On Wednesday 06 June 2012 17:50:41 Michael Eager wrote: > On 06/06/2012 11:13 AM, Mike Frysinger wrote: > > On Wednesday 06 June 2012 11:05:30 Michael Eager wrote: > >> On 06/06/2012 04:10 AM, Steven Bosscher wrote: > >>> Hello, > >>> > >>> I needed the attached patch to build the microblaze sim. > >>> Without the patch, bfd.h gives an #error that config.h should be > >>> included before it. > >>> > >>> Could you please see if this is OK, and commit it if so? > >> > >> Yes, I noticed this yesterday. > >> > >> Committed: > >> > >> 2012-06-06 Michael Eager<eager@eagercon.com> > >> > >> * microblaze/interp.c (config.h): Add #include. > > > > config.h should generally be the first header included, not like the 6th > > Moved to the top. thanks! -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-07 1:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CABu31nMez5xQ1mqwDUALJSNqvUmQo4sz2aniGK08qibTaksReg@mail.gmail.com>
2012-06-06 15:06 ` [patch][sim] Fix microblaze sim build Michael Eager
2012-06-06 18:13 ` Mike Frysinger
2012-06-06 21:50 ` Michael Eager
2012-06-07 1:37 ` Mike Frysinger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox