From: Michael Eager <eager@eagerm.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: binutils@sourceware.org, Michael Eager <eager@eagercon.com>,
Steven Bosscher <stevenb.gcc@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch][sim] Fix microblaze sim build
Date: Wed, 06 Jun 2012 21:50:00 -0000 [thread overview]
Message-ID: <4FCFD0B1.70308@eagerm.com> (raw)
In-Reply-To: <201206061413.35012.vapier@gentoo.org>
On 06/06/2012 11:13 AM, Mike Frysinger wrote:
> On Wednesday 06 June 2012 11:05:30 Michael Eager wrote:
>> On 06/06/2012 04:10 AM, Steven Bosscher wrote:
>>> Hello,
>>>
>>> I needed the attached patch to build the microblaze sim.
>>> Without the patch, bfd.h gives an #error that config.h should be
>>> included before it.
>>>
>>> Could you please see if this is OK, and commit it if so?
>>
>> Yes, I noticed this yesterday.
>>
>> Committed:
>>
>> 2012-06-06 Michael Eager<eager@eagercon.com>
>>
>> * microblaze/interp.c (config.h): Add #include.
>
> config.h should generally be the first header included, not like the 6th
> -mike
Moved to the top.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2012-06-06 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABu31nMez5xQ1mqwDUALJSNqvUmQo4sz2aniGK08qibTaksReg@mail.gmail.com>
2012-06-06 15:06 ` Michael Eager
2012-06-06 18:13 ` Mike Frysinger
2012-06-06 21:50 ` Michael Eager [this message]
2012-06-07 1:37 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCFD0B1.70308@eagerm.com \
--to=eager@eagerm.com \
--cc=binutils@sourceware.org \
--cc=eager@eagercon.com \
--cc=gdb-patches@sourceware.org \
--cc=stevenb.gcc@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox