From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5309 invoked by alias); 6 Jun 2012 21:50:56 -0000 Received: (qmail 5294 invoked by uid 22791); 6 Jun 2012 21:50:55 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from shell4.bayarea.net (HELO shell4.bayarea.net) (209.128.82.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jun 2012 21:50:42 +0000 Received: (qmail 547 invoked from network); 6 Jun 2012 14:50:41 -0700 Received: from c-76-102-3-160.hsd1.ca.comcast.net (HELO redwood.eagercon.com) (76.102.3.160) by shell4.bayarea.net with SMTP; 6 Jun 2012 14:50:41 -0700 Message-ID: <4FCFD0B1.70308@eagerm.com> Date: Wed, 06 Jun 2012 21:50:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mike Frysinger CC: binutils@sourceware.org, Michael Eager , Steven Bosscher , "gdb-patches@sourceware.org" Subject: Re: [patch][sim] Fix microblaze sim build References: <4FCF71BA.30001@eagercon.com> <201206061413.35012.vapier@gentoo.org> In-Reply-To: <201206061413.35012.vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00205.txt.bz2 On 06/06/2012 11:13 AM, Mike Frysinger wrote: > On Wednesday 06 June 2012 11:05:30 Michael Eager wrote: >> On 06/06/2012 04:10 AM, Steven Bosscher wrote: >>> Hello, >>> >>> I needed the attached patch to build the microblaze sim. >>> Without the patch, bfd.h gives an #error that config.h should be >>> included before it. >>> >>> Could you please see if this is OK, and commit it if so? >> >> Yes, I noticed this yesterday. >> >> Committed: >> >> 2012-06-06 Michael Eager >> >> * microblaze/interp.c (config.h): Add #include. > > config.h should generally be the first header included, not like the 6th > -mike Moved to the top. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077