Re: [patch#2] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory

[Hans-Peter Nilsson <hans-peter.nilsson@axis.com>]

> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Date: Mon, 4 Jun 2012 07:24:38 +0200

> On Mon, 04 Jun 2012 07:10:18 +0200, Hans-Peter Nilsson wrote:
> > > From: Jan Kratochvil <jan.kratochvil@redhat.com>
> > > Date: Fri, 1 Jun 2012 23:05:30 +0200
> > 
> > > bfd/
> > > 2012-06-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > > 
> > >     	* bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN argument
> > >     	of target_read_memory as bfd_size_type.
> > >     	* bfd-in2.h: Regenerate.
> > >     	* elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN
> > >     	argument of target_read_memory as size_t.
> > (..."as bfd_size_type.")
> > 
> > >     	(_bfd_elf32_bfd_from_remote_memory): Likewise.
> > >     	(_bfd_elf64_bfd_from_remote_memory): Likewise.
> > >     	* elf.c (bfd_elf_bfd_from_remote_memory): Likewise.
> > >     	* elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise.
> > >     
> > > gdb/
> > > 2012-06-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > > 
> > > 	* symfile-mem.c: 3 new gdb_static_assert for target_read_memory_bfd
> > > 	parameters.
> > > 	(target_read_memory_bfd): New function.
> > > 	(symbol_file_add_from_memory): Use it.
> > 
> > If this is ready to commit and you don't have the time today,
> > just say the word.
> 
> I believe I need bfd/ approval by Alan or other bfd/ maintainer.

(I take it all necessary testing is done, then.)

If it'd been me, I'd interpret Alan's: "since Jan has already
given the OK, and these functions are only used by gdb, binutils
maintainers hardly need to look at the patch" (regarding the
earlier corresponding breaking change to size_t) as an intent of
delegation of these bits, but that may be a bit wild.  In the
meantime, there's a broken tree.

brgds, H-P